This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Changes DlColor to support wide gamut colors (#54473)" #54636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
This reverts commit 93e5c81.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Aug 20, 2024
auto-submit
bot
deleted the
revert_93e5c810a6c767b4ca52f83aef8b3dd9121d0af4
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 20, 2024
…153739) flutter/engine@5355c0b...86f269b 2024-08-20 [email protected] Roll Skia from e65e02c50d66 to 30a00629e135 (3 revisions) (flutter/engine#54634) 2024-08-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Changes DlColor to support wide gamut colors (#54473)" (flutter/engine#54636) 2024-08-19 [email protected] [Impeller] account for negative scale in max basis xy. (flutter/engine#54630) 2024-08-19 [email protected] Changes DlColor to support wide gamut colors (flutter/engine#54473) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153739) flutter/engine@5355c0b...86f269b 2024-08-20 [email protected] Roll Skia from e65e02c50d66 to 30a00629e135 (3 revisions) (flutter/engine#54634) 2024-08-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Changes DlColor to support wide gamut colors (flutter#54473)" (flutter/engine#54636) 2024-08-19 [email protected] [Impeller] account for negative scale in max basis xy. (flutter/engine#54630) 2024-08-19 [email protected] Changes DlColor to support wide gamut colors (flutter/engine#54473) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #54473
Initiated by: jonahwilliams
Reason for reverting: golden diffs like https://flutter-engine-gold.skia.org/detail?grouping=name%3Dimpeller_Play_AiksTest_BlendModeSrcAlphaLuminosity_OpenGLES%26source_type%3Dflutter-engine&digest=107ccd2cd1170746b1ffc4d31184e789 look incorrect, potentially an alpha issue
Original PR Author: gaaclarke
Reviewed By: {flar}
This change reverts the following previous change:
issue: flutter/flutter#127855
integration test: #54415
This is the engine side changes required for wide gamut framework support. It changes the internal representation of DlColor to be floats. It will be married with #54415 when it lands in #54567.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.