This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] dont apply opacity peephole to runtime effect. #56621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
suggested changes
Nov 15, 2024
| !paint.mask_blur_descriptor.has_value() && | ||
| paint.image_filter == nullptr && paint.color_filter == nullptr; | ||
| } | ||
| static bool CanApplyOpacityPeephole(const Paint& paint); |
There was a problem hiding this comment.
SaveLayer operations ignore the color source. If this is having an impact then something must be going wrong in how we handle SaveLayers.
flar
reviewed
Nov 15, 2024
| if (paint.blend_mode != BlendMode::kSourceOver) { | ||
| return false; | ||
| } | ||
| if (paint.invert_colors || paint.mask_blur_descriptor.has_value() || |
There was a problem hiding this comment.
Also, SaveLayer shouldn't apply mask blur either.
Only alpha of the color, IF, CF and blend.
jonahwilliams
commented
Nov 15, 2024
|
I think the error here is that this test is looking for the attributes on the SaveLayer, but it really should be concerned about the attributes on the content. (Note that this may work accidentally in cases where an RT ColorSource or ImageFilter was installed by a previous rendering op, but the SaveLayer call did not clear that attribute because it wasn't planning to use it.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#158500
Runtime effect cannot accept opacity.