Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove the vestiges of ActiveDOMObject and EventTargetNames, which I missed in my recent patch #61

Merged
merged 1 commit into from
Jul 16, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sky/engine/bindings/IDLExtendedAttributes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
# arbitrary, but that "X" is standard, e.g. [Attr=X], [Attr=Foo].
#

ActiveDOMObject
CachedAttribute=*
CallWith=ScriptState|ScriptArguments|ActiveWindow|FirstWindow|ThisValue
Constructor
Expand Down
1 change: 0 additions & 1 deletion sky/engine/bindings/scripts/code_generator_dart.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ def generate_code(self, definitions, interface_name,
interface_global = {'component_dir': interface_info['component_dir'],
'name': template_contents['interface_name'],
'parent_interface': template_contents['parent_interface'],
'is_active_dom_object': template_contents['is_active_dom_object'],
'has_resolver': template_contents['interface_name'],
'native_entries': sorted(template_contents['native_entries'], key=lambda(x): x['blink_entry']),
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@
from utilities import read_pickle_files, write_pickle_file

INHERITED_EXTENDED_ATTRIBUTES = set([
'ActiveDOMObject',
'DependentLifetime',
'NotScriptWrappable',
])
Expand Down
5 changes: 0 additions & 5 deletions sky/engine/bindings/scripts/v8_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ def interface_context(interface):
header_includes.update(v8_types.includes_for_interface(parent_interface))
extended_attributes = interface.extended_attributes

# [ActiveDOMObject]
is_active_dom_object = 'ActiveDOMObject' in extended_attributes

# [DependentLifetime]
is_dependent_lifetime = 'DependentLifetime' in extended_attributes

Expand Down Expand Up @@ -134,14 +131,12 @@ def interface_context(interface):
'has_visit_dom_wrapper': has_visit_dom_wrapper,
'header_includes': header_includes,
'interface_name': interface.name,
'is_active_dom_object': is_active_dom_object,
'is_dependent_lifetime': is_dependent_lifetime,
'is_exception': interface.is_exception,
'is_script_wrappable': is_script_wrappable,
'iterator_method': iterator_method,
'lifetime': 'Dependent'
if (has_visit_dom_wrapper or
is_active_dom_object or
is_dependent_lifetime)
else 'Independent',
'parent_interface': parent_interface,
Expand Down
1 change: 0 additions & 1 deletion sky/engine/core/css/MediaQueryList.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/

#include "sky/engine/core/css/MediaQueryList.h"
#include "gen/sky/core/EventTargetNames.h"
#include "sky/engine/core/css/MediaList.h"
#include "sky/engine/core/css/MediaQueryEvaluator.h"
#include "sky/engine/core/css/MediaQueryListListener.h"
Expand Down
3 changes: 1 addition & 2 deletions sky/engine/platform/AsyncMethodRunner.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ class AsyncMethodRunner final {
}

// If it's scheduled to run the method, cancel it and remember to schedule
// it again when resume() is called. Mainly for implementing
// ActiveDOMObject::suspend().
// it again when resume() is called.
void suspend()
{
if (m_suspended)
Expand Down