This repository was archived by the owner on Feb 25, 2025. It is now read-only.
RenderObjectWrapper cleanup and new asserts. #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hixie
commented
Aug 19, 2015
Hixie
commented
- Clarify comment about RenderObjectWrapper.
- Assert that we never sync a RenderObjectWrapper with an instance of a different type.
- Assert that MultiChildRenderObjectWrapper subclasses always have multi-child RenderObjects.
- Assert that renderObject doesn't change identity when syncing.
- Make searchForOldNode() return void since the return value is ignored.
- Remove code that handled renderObject changing during sync.
- Clarify comment about RenderObjectWrapper. - Assert that we never sync a RenderObjectWrapper with an instance of a different type. - Assert that MultiChildRenderObjectWrapper subclasses always have multi-child RenderObjects. - Assert that renderObject doesn't change identity when syncing. - Make searchForOldNode() return void since the return value is ignored. - Remove code that handled renderObject changing during sync.
|
LGTM |
abarth
added a commit
that referenced
this pull request
Aug 20, 2015
RenderObjectWrapper cleanup and new asserts.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Bump to 1.1.0. * Update CHANGELOG. (And update bump script to do it automatically.)
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Fix leftover $ inline latexmath
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.