sample creation banner #3113
sample creation banner #3113
Conversation
|
@pq This is pretty cool! I want to patch it in and play around with it before finishing my review. Can I assume you're in no hurry since it is tagged for M33? |
|
Thanks @stevemessick. No rush. Definitely an |
| // Combo or label. | ||
| JComponent sampleSelector; | ||
|
|
||
| FlutterSampleActionsPanel(@NotNull List<FlutterSample> samples, @NotNull Project project) { |
There was a problem hiding this comment.
I wonder if we can tighten up the layout of this panel? It takes a lot more vertical space than others and I didn't see an obvious need for that.
There was a problem hiding this comment.
Totally. Trimmed by 5px:
We can tweak more too.
| myLabel.setText("Open sample project:"); | ||
| myLabel.setBorder(JBUI.Borders.emptyRight(5)); | ||
|
|
||
| goLink = new JBLabel("<html><a href=\"\">Go...</a></html>"); |
There was a problem hiding this comment.
"Go..." might be a bit too terse. Maybe "Open"? There is no user input so no need for ellipsis.
There was a problem hiding this comment.
Hmmmm...
Looks a little off?
Thoughts welcome!
There was a problem hiding this comment.
Agreed, "Open" twice is redundant. But the label could be changed to removed "Open". As a former Smalltalker, I'm obliged to suggest "Do It" (in jest).
|
Thanks! I plan to do another pass after some feedback from @InMatrix so I'll leave it as is. As for "do it", that sure does bring me back
sigh Would that this were Smalltalk! 😢 |
Adds a sample creation banner to framework files w/ samples.
In the common (and current case), presents a simple label for the active sample.
In case there is more than one sample (promised for the future), provides a chooser.
(Note this example above is showing more IDs than are appropriate for this file in order to demo the chooser behavior.)
NOTE: not for landing in M32 since we'll need to shore up the implementation in Android Studio.
/cc @stevemessick
Fixes: #2976.