-
Notifications
You must be signed in to change notification settings - Fork 327
Add sample apps to AS NPW #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -123,7 +123,7 @@ private void createUIComponents() { | |||
projectTypeCombo.addItemListener(e -> { | |||
final boolean appType = getType() == FlutterProjectType.APP; | |||
if (!appType) { | |||
// Make sure sample generattion is de-selected in non-app contexts. | |||
// Make sure sample generation is de-selected in non-app contexts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬
@lukeburford: if you quite Android Studio and re-open it, is the list still empty? |
Another test is: don't exit intellij but cancel the wizard and restart.
That often works for me, and surprisingly it doesn't seem to be affected by
network speed.
…On Wed, May 1, 2019, 5:11 PM Phil Quitslund ***@***.***> wrote:
@lukeburford <https://github.com/lukeburford>: if you quite Android
Studio and re-open it, is the list still empty?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3134 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACA7VDMWLB6HHZNLV7CD4YDPTIWURANCNFSM4GS2LHLA>
.
|
Both cancelling the wizard and quitting/restarting have no effect I'm afraid, still a blank dropdown list. |
Thanks for checking @lukeburford. Could you run |
[✓] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.4 18E227, locale en-GB) [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) [✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1) [✓] Android Studio (version 3.4) [✓] VS Code (version 1.33.1) [!] Connected device ! Doctor found issues in 1 category. |
Same issue here. Installed Flutter back in December of 2018 when 1.0 came out, installed all Flutter/Dart/Emulator upgrades available on the stable channel. D:\flutter\bin\flutter.bat doctor --verbose [√] Android toolchain - develop for Android devices (Android SDK version 28.0.3) [√] Android Studio (version 3.4) [√] VS Code (version 1.33.1) [!] Connected device ! Doctor found issues in 1 category. |
Hey all, thanks for the feedback. The problem with populating the samples pulldown is being tracked here: #3429. You can follow (or thumbs up) that issue to be updated about progress. |
Today Android Studio told me a new update is available. Now Flutter is at v1.5.4-hotfix.2 and the sample content is available. Thank you! |
@pq @devoncarew
Add the option to generate sample content when creating a new app.
Reused the ProjectType form. (Hopefully we still have the magic to compile shared forms in the plugin build tool.) That lower-case "g" bugs me but that's a separate issue.