Skip to content

Add sample apps to AS NPW #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Add sample apps to AS NPW #3134

merged 1 commit into from
Jan 28, 2019

Conversation

stevemessick
Copy link
Member

@pq @devoncarew

Add the option to generate sample content when creating a new app.

screen shot 2019-01-28 at 11 06 08 am

Reused the ProjectType form. (Hopefully we still have the magic to compile shared forms in the plugin build tool.) That lower-case "g" bugs me but that's a separate issue.

@stevemessick stevemessick requested a review from pq January 28, 2019 19:15
Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks great!

@@ -123,7 +123,7 @@ private void createUIComponents() {
projectTypeCombo.addItemListener(e -> {
final boolean appType = getType() == FlutterProjectType.APP;
if (!appType) {
// Make sure sample generattion is de-selected in non-app contexts.
// Make sure sample generation is de-selected in non-app contexts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@lukeburford
Copy link

lukeburford commented May 2, 2019

The dropdown seems to be blank in a fresh install of Android Studio 3.4 on macOS?
Screenshot 2019-05-02 at 00 53 53

@pq
Copy link
Contributor

pq commented May 2, 2019

@lukeburford: if you quite Android Studio and re-open it, is the list still empty?

@stevemessick
Copy link
Member Author

stevemessick commented May 2, 2019 via email

@lukeburford
Copy link

Both cancelling the wizard and quitting/restarting have no effect I'm afraid, still a blank dropdown list.

@pq
Copy link
Contributor

pq commented May 2, 2019

Thanks for checking @lukeburford.

Could you run flutter doctor -v and paste the results?

@lukeburford
Copy link

[✓] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.4 18E227, locale en-GB)
• Flutter version 1.2.1 at /Users/luke/flutter
• Framework revision 8661d8aecd (3 months ago), 2019-02-14 19:19:53 -0800
• Engine revision 3757390fa4
• Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/luke/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.2.1, Build version 10E1001
• ios-deploy 1.9.4
• CocoaPods version 1.6.0

[✓] Android Studio (version 3.4)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 35.1.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] VS Code (version 1.33.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 2.26.1

[!] Connected device
! No devices available

! Doctor found issues in 1 category.

@vvinogradsky
Copy link

vvinogradsky commented May 2, 2019

Same issue here. Installed Flutter back in December of 2018 when 1.0 came out, installed all Flutter/Dart/Emulator upgrades available on the stable channel.

D:\flutter\bin\flutter.bat doctor --verbose
[√] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Version 6.1.7601], locale en-US)
• Flutter version 1.2.1 at D:\flutter
• Framework revision 8661d8aecd (3 months ago), 2019-02-14 19:19:53 -0800
• Engine revision 3757390fa4
• Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at D:/Android/SDK
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = D:/Android/SDK
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.

[√] Android Studio (version 3.4)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 35.1.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[√] VS Code (version 1.33.1)
• VS Code at C:\Users\vvinogradsky\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 2.26.1

[!] Connected device
! No devices available

! Doctor found issues in 1 category.
Process finished with exit code 0

@devoncarew
Copy link
Member

Hey all, thanks for the feedback. The problem with populating the samples pulldown is being tracked here: #3429. You can follow (or thumbs up) that issue to be updated about progress.

@vvinogradsky
Copy link

Today Android Studio told me a new update is available. Now Flutter is at v1.5.4-hotfix.2 and the sample content is available. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants