Make Dart constructor calls pop out in light mode. #3327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes FYI @InMatrix in case there is a different color we should use. Long term it would be nice but not crucial if this color default is added to the Dart Plugin but it makes sense to add it to the Flutter plugin so we can get quick feedback and iterate if need be. |
|
Can we try this color: #2196f3. It's blue[500] in material design and it feels slightly more solid than the one used now. |
…lready nicely visible in Darkula mode.
jacob314
force-pushed
the
code_color_scheme
branch
from
6ffdde7 to
1778aa2
Compare
|
That new color looks really nice and does make me wonder about creating a full material design colors only color scheme for Dart/Flutter. :) |
stevemessick
approved these changes
Mar 29, 2019
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
* Make Dart constructor calls pop out in light mode. Constructors are already nicely visible in Darkula mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors are already nicely visible in Darkula mode.
Having this separate color style format will be handy for future additional UI as Code related
color tweaks. Here are screenshots of what this looks like in action. The Dark theme isn't
impacted but the light theme is.