Continued removal of deprecated or dead code #7711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the EditorMouseEventService.java and EditorPositionService.java project services Continuation of https:/ /github.com/flutter/pull/7710 and flutter#7706
jwren
added a commit
to jwren/flutter-intellij
that referenced
this pull request
Oct 15, 2024
This PR removes more of the old Inspector view code, also deleting usage of deprecated APIs Continuation of flutter#7711, flutter#7710 and flutter#7706
There was a problem hiding this comment.
Will these services be necessary for the property editor? We can always add them back if so, but we'll need functionality to get the widget at the current cursor position so that DevTools can ask the analysis server for the editable properties of this widget.
|
Services yes, but not these. These mouse event listeners/handlers are compute the widget in context using the Flutter Outline computed information which is not as robust as the upcoming DTD & DevTools work. |
kenzieschmoll
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the EditorMouseEventService.java and EditorPositionService.java project services
Continuation of #7710 and #7706