Skip to content

Typo "SetTestFluttterStub" in stub_flutter_windows_api.h #104370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nilsreichardt opened this issue May 22, 2022 · 1 comment · Fixed by flutter/engine#33551
Closed

Typo "SetTestFluttterStub" in stub_flutter_windows_api.h #104370

nilsreichardt opened this issue May 22, 2022 · 1 comment · Fixed by flutter/engine#33551
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-windows Building on or for Windows specifically waiting for PR to land (fixed) A fix is in flight

Comments

@nilsreichardt
Copy link
Contributor

https://github.com/flutter/engine/blob/27ca4dffdc0ab0596d3c290b69259bc630561b3b/shell/platform/common/client_wrapper/testing/stub_flutter_api.h#L32
This was referenced May 22, 2022
Closed
Merged
@darshankawar darshankawar added in triage Presently being triaged by the triage team engine flutter/engine repository. See also e: labels. platform-windows Building on or for Windows specifically and removed in triage Presently being triaged by the triage team labels May 23, 2022
@chinmaygarde chinmaygarde added waiting for PR to land (fixed) A fix is in flight P2 Important issues not at the top of the work list labels May 23, 2022
cbracken pushed a commit to flutter/engine that referenced this issue May 23, 2022
@nilsreichardt
Fix typo "SetTestFluttterStub", "FluttterActivity" and "implementanti…
e0ba7c6 
…ons" (#33551)

As recommended in #33547 (comment), I fixed all typos in one PR.

Fixes flutter/flutter#104366
Fixes flutter/flutter#104367
Fixes flutter/flutter#104368
Fixes flutter/flutter#104369
Fixes flutter/flutter#104370
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
houhuayong pushed a commit to houhuayong/engine that referenced this issue Jun 21, 2022
@nilsreichardt @houhuayong
Fix typo "SetTestFluttterStub", "FluttterActivity" and "implementanti…
3506428 
…ons" (flutter#33551)

As recommended in flutter#33547 (comment), I fixed all typos in one PR.

Fixes flutter/flutter#104366
Fixes flutter/flutter#104367
Fixes flutter/flutter#104368
Fixes flutter/flutter#104369
Fixes flutter/flutter#104370
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-windows Building on or for Windows specifically waiting for PR to land (fixed) A fix is in flight
Projects
None yet
Milestone
No milestone
3 participants
@chinmaygarde @nilsreichardt @darshankawar