Skip to content

Use const constructor for ParagraphConstraints #26390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cbracken opened this issue Jan 10, 2019 · 1 comment · Fixed by #26990
Closed

Use const constructor for ParagraphConstraints #26390

cbracken opened this issue Jan 10, 2019 · 1 comment · Fixed by #26990
Assignees
@cbracken
Labels
framework flutter/packages/flutter repository. See also f: labels.

Comments

@cbracken
Copy link
Member

cbracken commented Jan 10, 2019 •
edited
Loading

Usages of ParagraphConstraints (from dart:ui) whose constructor could be const as of flutter/engine#7346 are currently marked // ignore:prefer_const_constructors in the framework until all Google-internal embedders have been updated to an engine version that includes the above change. These were initially updated in engine roll #26252, but broke internal embedders so were reverted in #26392.

We should re-enable use of the const constructor in those cases once internal embedders are updated.
@cbracken cbracken added the framework flutter/packages/flutter repository. See also f: labels. label Jan 10, 2019
@cbracken cbracken self-assigned this Jan 10, 2019
cbracken added a commit to cbracken/flutter that referenced this issue Jan 10, 2019
@cbracken
Avoid use of ParagraphConstrains const ctor
06c46e0 
Usages of ParagraphConstraints (from dart:ui) whose constructor could be
const as of flutter/engine#7346 are currently marked //
ignore:prefer_const_constructors in the framework until all
Google-internal embedders have been updated to an engine version that
includes the above change. These were initially updated in engine roll
flutter#26252, but broke internal embedders.

We should re-enable use of the const constructor in those cases once
internal embedders are updated.

See: flutter#26390
@cbracken cbracken mentioned this issue Jan 10, 2019
Merged
cbracken added a commit that referenced this issue Jan 11, 2019
@cbracken
Avoid use of ParagraphConstrains const ctor (#26392)
88b77a7 
Usages of ParagraphConstraints (from dart:ui) whose constructor could be
const as of flutter/engine#7346 are currently marked //
ignore:prefer_const_constructors in the framework until all
Google-internal embedders have been updated to an engine version that
includes the above change. These were initially updated in engine roll
#26252, but broke internal embedders.

We should re-enable use of the const constructor in those cases once
internal embedders are updated.

See: #26390
@cbracken cbracken mentioned this issue Jan 23, 2019
Merged
cbracken added a commit that referenced this issue Jan 24, 2019
@cbracken
Re-enable use of ParagraphConstrains const ctor (#26990)
65a70bc 
All embedders of Flutter within Google have all been updated to an
engine version that includes the const constructor added in
flutter/engine#7346 and rolled into the framework in
#26252.

This reverts commit 88b77a7.

This fixes #26390.
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this issue Feb 12, 2019
@cbracken @kangwang1988
Avoid use of ParagraphConstrains const ctor (flutter#26392)
76f3683 
Usages of ParagraphConstraints (from dart:ui) whose constructor could be
const as of flutter/engine#7346 are currently marked //
ignore:prefer_const_constructors in the framework until all
Google-internal embedders have been updated to an engine version that
includes the above change. These were initially updated in engine roll
flutter#26252, but broke internal embedders.

We should re-enable use of the const constructor in those cases once
internal embedders are updated.

See: flutter#26390
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this issue Feb 12, 2019
@cbracken @kangwang1988
Re-enable use of ParagraphConstrains const ctor (flutter#26990)
213da02 
All embedders of Flutter within Google have all been updated to an
engine version that includes the const constructor added in
flutter/engine#7346 and rolled into the framework in
flutter#26252.

This reverts commit 88b77a7.

This fixes flutter#26390.
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cbracken cbracken

Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable use of ParagraphConstrains const ctor cbracken/flutter
1 participant
@cbracken