-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Use const constructor for ParagraphConstraints #26390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
framework
flutter/packages/flutter repository. See also f: labels.
Comments
cbracken
added a commit
to cbracken/flutter
that referenced
this issue
Jan 10, 2019
Usages of ParagraphConstraints (from dart:ui) whose constructor could be const as of flutter/engine#7346 are currently marked // ignore:prefer_const_constructors in the framework until all Google-internal embedders have been updated to an engine version that includes the above change. These were initially updated in engine roll flutter#26252, but broke internal embedders. We should re-enable use of the const constructor in those cases once internal embedders are updated. See: flutter#26390
cbracken
added a commit
that referenced
this issue
Jan 11, 2019
Usages of ParagraphConstraints (from dart:ui) whose constructor could be const as of flutter/engine#7346 are currently marked // ignore:prefer_const_constructors in the framework until all Google-internal embedders have been updated to an engine version that includes the above change. These were initially updated in engine roll #26252, but broke internal embedders. We should re-enable use of the const constructor in those cases once internal embedders are updated. See: #26390
cbracken
added a commit
that referenced
this issue
Jan 24, 2019
All embedders of Flutter within Google have all been updated to an engine version that includes the const constructor added in flutter/engine#7346 and rolled into the framework in #26252. This reverts commit 88b77a7. This fixes #26390.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this issue
Feb 12, 2019
Usages of ParagraphConstraints (from dart:ui) whose constructor could be const as of flutter/engine#7346 are currently marked // ignore:prefer_const_constructors in the framework until all Google-internal embedders have been updated to an engine version that includes the above change. These were initially updated in engine roll flutter#26252, but broke internal embedders. We should re-enable use of the const constructor in those cases once internal embedders are updated. See: flutter#26390
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this issue
Feb 12, 2019
All embedders of Flutter within Google have all been updated to an engine version that includes the const constructor added in flutter/engine#7346 and rolled into the framework in flutter#26252. This reverts commit 88b77a7. This fixes flutter#26390.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
Usages of ParagraphConstraints (from
dart:ui
) whose constructor could beconst
as of flutter/engine#7346 are currently marked// ignore:prefer_const_constructors
in the framework until all Google-internal embedders have been updated to an engine version that includes the above change. These were initially updated in engine roll #26252, but broke internal embedders so were reverted in #26392.We should re-enable use of the const constructor in those cases once internal embedders are updated.
The text was updated successfully, but these errors were encountered: