FlutterDesktopEngineCreate takes argument by reference #75465
Labels
a: desktop
Running on desktop
engine
flutter/engine repository. See also e: labels.
P2
Important issues not at the top of the work list
platform-windows
Building on or for Windows specifically
Comments
knopp
added
platform-windows
knopp
changed the title
|
That should definitely be fixed, the sooner the better to minimize possible breaks (in practice, probably nobody will be broken because the template only uses the wrapper). It's there because for some reason I'm incapable of remembering that references are C++, not C. /cc @cbracken |
pedromassangocode
added
engine
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Apr 6, 2021
FlutterDesktopEngineCreate is part of our C API. We were using a C++ reference type instead of a C-compatible pointer type. This is a breaking change to anyone calling this directly; we believe this should affect few people because the Windows template only uses the `FlutterEngine` wrapper in `shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h`. Fixes flutter/flutter#75465
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Apr 6, 2021
FlutterDesktopEngineCreate is part of our C API. We were using a C++ reference type instead of a C-compatible pointer type. This is a breaking change to anyone calling this directly; we believe this should affect few people because the Windows template only uses the `FlutterEngine` wrapper in `shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h`. Fixes flutter/flutter#75465
9 tasks
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Apr 6, 2021
FlutterDesktopEngineCreate is part of our C API. We were using a C++ reference type instead of a C-compatible pointer type. This is a breaking change to anyone calling this directly; we believe this should affect few people because the Windows template only uses the `FlutterEngine` wrapper in `shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h`. Fixes flutter/flutter#75465
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Apr 6, 2021
FlutterDesktopEngineCreate is part of our C API. We were using a C++ reference type instead of a C-compatible pointer type. This is a breaking change to anyone calling this directly; we believe this should affect few people because the Windows template only uses the `FlutterEngine` wrapper in `shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h`. Fixes flutter/flutter#75465
cbracken
added a commit
to flutter/engine
that referenced
this issue
Apr 6, 2021
FlutterDesktopEngineCreate is part of our C API. We were using a C++ reference type instead of a C-compatible pointer type. This is a breaking change to anyone calling this directly; we believe this should affect few people because the Windows template only uses the `FlutterEngine` wrapper in `shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h`. Fixes flutter/flutter#75465
duanqz
pushed a commit
to duanqz/engine
that referenced
this issue
Apr 16, 2021
FlutterDesktopEngineCreate is part of our C API. We were using a C++ reference type instead of a C-compatible pointer type. This is a breaking change to anyone calling this directly; we believe this should affect few people because the Windows template only uses the `FlutterEngine` wrapper in `shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h`. Fixes flutter/flutter#75465
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm not sure how much of a problem this in practice, but I'm bringing this up just in case.
The methods in
flutter_windows.hare declared as extern "C", butFlutterDesktopEngineCreatetakesengine_propertiesby const reference, which is not a C thing.Right now calling it with a pointer (i.e. through FFI or from Rust) works, and I don't suppose it's going to change in future, but it seems like it's relying on unspecified behavior.
The text was updated successfully, but these errors were encountered: