Fix a DataTable crash and improve some docs
#100959
Conversation
flutter-dashboard
bot
added
f: material design
| /// by default, this widget will only occupy minimal space. It is | ||
| /// recommended to wrap this with an [Expanded] or [Flexible] to control how | ||
| /// it flexes. Otherwise, an exception will occur when the the available space | ||
| /// is insufficient. |
|
@dkwingsmt Hi, would you like take a look at this patch : ) |
|
(I'm sorry for failing to notice this!) |
| /// This widget and the sort indicator (if visible) will wrap with a [Row], | ||
| /// by default, this widget will only occupy minimal space. It is |
There was a problem hiding this comment.
The first sentence doesn't make much sense. Depending on what you mean, maybe
The [label] is placed within a [Row] along with the sort indicator (if applicable). By default, [label] only occupy minimal space.
| /// you can wrap it with an [Expanded]. | ||
| /// This widget and the sort indicator (if visible) will wrap with a [Row], | ||
| /// by default, this widget will only occupy minimal space. It is | ||
| /// recommended to wrap this with an [Expanded] or [Flexible] to control how |
There was a problem hiding this comment.
It is recommended to place the label content in an [Expanded] or [Flexible] as [label] to control how the content flexes.
| @@ -1050,26 +1051,26 @@ class RenderTable extends RenderBox { | |||
| if (rows * columns == 0) { | |||
| // TODO(ianh): if columns is zero, this should be zero width | |||
| // TODO(ianh): if columns is not zero, this should be based on the column width specifications | |||
| _tableWidth = 0.0; | |||
There was a problem hiding this comment.
Does this resolve the TODOs?
There was a problem hiding this comment.
I am not quite understood what the todos mean, but I think maybe they can be removed.
As you have said here, this may break something. |
| /// sort indicator (if applicable). By default, [label] only occupy minimal | ||
| /// space. It is recommended to place the label content in an [Expanded] or | ||
| /// [Flexible] as [label] to control how the content flexes. Otherwise, | ||
| /// an exception will occur when the the available space is insufficient. |
There was a problem hiding this comment.
| /// an exception will occur when the the available space is insufficient. | |
| /// an exception will occur when the available space is insufficient. |
Fixes #100952
Fixes #100633