-
Notifications
You must be signed in to change notification settings - Fork 28.5k
[Docs] Clarify that Flex does not wrap #113404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
My editor seems to have auto formatted the code here. If desired, I will amend this tomorrow using "save without formatting" |
Also, re:tests, these changes are docs-only. |
cda6b3a
to
9715a22
Compare
9715a22
to
6c4703a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
Flex
widget, despite its name, differs from the behaviour offlexbox
in a web setting. In particular, people coming from a web background may be used to usingflex-wrap: wrap
from CSS, whichFlex
does not support. This PR attempts to elide this confusion by pointing to theWrap
widget from the documentation forFlex
.Although these additions are aiming to avoid confusion with flexbox, I was careful not to specifically mention the web use case, so as not to further confuse anyone who wouldn't have otherwise been confused.
Fixes #113403 113403
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.