-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Enable prefer_mixin #123159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable prefer_mixin #123159
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I should update the bot to ignore this type of PR |
test-exempt: adds lint |
Now that we have the mixin modifier, dart-lang/sdk#58543 is no longer a blocker for this lint.
However, there are a handful of classes used as mixin from package:file, which has not been updated to use the mixin modifier yet. That work is tracked in https://github.com/google/file.dart/issues/209. I added ignores for those for the time being.