Added filter callback on dropdown menu #143939

dacianf · 2024-02-22T15:44:33Z

I added a callback on DropDown Menu for filtering options. I needed this feature because I wanted to filtered data using a custom way and that was not possible. For searching there was already a callback that helped, but none for filtering.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-03-31T14:50:11Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

dacianf · 2024-04-12T14:01:31Z

@QuncCccccc any idea when you can look over this PR?

QuncCccccc · 2024-04-12T18:54:42Z

@QuncCccccc any idea when you can look over this PR?

Hi! Sorry for the late response! Overall this is a reasonable feature, will take a look very soon!

packages/flutter/lib/src/material/dropdown_menu.dart

packages/flutter/test/material/dropdown_menu_test.dart

packages/flutter/lib/src/material/dropdown_menu.dart

packages/flutter/test/material/dropdown_menu_test.dart

dacianf · 2024-04-29T21:07:37Z

@QuncCccccc can you take one more look here, please?

dacianf · 2024-05-02T13:17:01Z

@QuncCccccc any updates?

dacianf · 2024-05-14T21:04:49Z

@QuncCccccc are you still around? @HansMuller Should I contact someone else?

QuncCccccc

Thanks for your patience! Just left some comments below. After fixing these, we should good to go!

packages/flutter/lib/src/material/dropdown_menu.dart

QuncCccccc · 2024-05-30T23:59:28Z

Ah I didn't realize there was already enableSearch and searchCallback. I don't want to overly complicate things then. @QuncCccccc did you originally write enableSearch and serachCallback? Do you think it's worth it to migrate all of them or just keep everything as-is?

I think we can just keep it as-is for now, but at the same time we might want to add an assertion to make sure when filterCallback is not null, enableFilter must has been set to true, something like assert(filterCallback == null || filterCallback != null && enableFilter == true). Thanks @justinmc for your suggestions!

dacianf · 2024-05-31T17:12:58Z

@QuncCccccc I added it. Wasn't sure if I needed to add a comment there or not.

QuncCccccc

LGTM with some suggestions below.

Just noticed I didn't click Approve last time. I will ask the second review when the comments are fixed:)! Thanks again for the contribution!

packages/flutter/lib/src/material/dropdown_menu.dart

dacianf · 2024-05-31T21:09:19Z

LGTM with some suggestions below.

Just noticed I didn't click Approve last time. I will ask the second review when the comments are fixed:)! Thanks again for the contribution!

No worries @QuncCccccc ! I fixed the comments!

Thank you too for helping me getting it done!

justinmc

@dacianf I wonder what you think about this comment about possibly setting a default value for filterCallback: https://github.com/flutter/flutter/pull/143939/files#r1621190671

Otherwise everything else is nits and this PR looks good.

packages/flutter/lib/src/material/dropdown_menu.dart

packages/flutter/test/material/dropdown_menu_test.dart

remove redundant code revert changes on `_enableFilter` variable fixes based on PR comments Update packages/flutter/test/material/dropdown_menu_test.dart

Co-authored-by: Qun Cheng <[email protected]>

justinmc

LGTM 👍 . Thanks for answering all of my questions and making those fixes!

justinmc · 2024-06-03T18:16:47Z

packages/flutter/lib/src/material/dropdown_menu.dart

@@ -162,6 +168,7 @@ class DropdownMenu<T> extends StatefulWidget {
    this.focusNode,
    this.requestFocusOnTap,
    this.expandedInsets,
+    this.filterCallback,


Ok agreed, it makes sense to do this the same way as searchCallback for now.

…pdate * master: (168 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2353b6 to a6aa5d826649 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558be758 to 60a7bb2353b6 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf635a9f to ea72558be758 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d7459708 to d81edf635a9f (1 revision) (flutter#149468) Roll Flutter Engine from 40b868efcc46 to b0f4d7459708 (1 revision) (flutter#149467) ...

…pdate * master: (181 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2353b6 to a6aa5d826649 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558be758 to 60a7bb2353b6 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf635a9f to ea72558be758 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d7459708 to d81edf635a9f (1 revision) (flutter#149468) Roll Flutter Engine from 40b868efcc46 to b0f4d7459708 (1 revision) (flutter#149467) ...

* master: (181 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2353b6 to a6aa5d826649 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558be758 to 60a7bb2353b6 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf635a9f to ea72558be758 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d7459708 to d81edf635a9f (1 revision) (flutter#149468) Roll Flutter Engine from 40b868efcc46 to b0f4d7459708 (1 revision) (flutter#149467) ...

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from 8aa47ee to 4f34899 Compare February 22, 2024 15:44

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 22, 2024

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch 2 times, most recently from 9b9a75c to 3ed4b29 Compare February 26, 2024 15:34

HansMuller requested a review from QuncCccccc February 29, 2024 23:45

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch 2 times, most recently from 6201d0d to d61b4e1 Compare March 11, 2024 14:48

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from d61b4e1 to 4e6c9b0 Compare April 12, 2024 14:01

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch 5 times, most recently from fd6e724 to 7c621a4 Compare April 16, 2024 16:00

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from 7c621a4 to 6fe0afd Compare April 23, 2024 13:50

QuncCccccc reviewed Apr 23, 2024

View reviewed changes

dacianf requested a review from QuncCccccc April 25, 2024 09:11

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch 2 times, most recently from e16bd71 to d6fd5aa Compare April 29, 2024 21:07

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from d6fd5aa to d0e6777 Compare May 2, 2024 13:12

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from d0e6777 to 815379e Compare May 14, 2024 21:03

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from 815379e to eef9a56 Compare May 15, 2024 09:23

QuncCccccc reviewed May 20, 2024

View reviewed changes

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from eef9a56 to ec9eec8 Compare May 21, 2024 06:18

dacianf requested a review from victorsanni May 31, 2024 17:12

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from 51fb0b2 to 4632fe9 Compare May 31, 2024 17:32

QuncCccccc approved these changes May 31, 2024

View reviewed changes

packages/flutter/lib/src/material/dropdown_menu.dart Show resolved Hide resolved

packages/flutter/lib/src/material/dropdown_menu.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/dropdown_menu.dart Outdated Show resolved Hide resolved

justinmc reviewed May 31, 2024

View reviewed changes

dacianf and others added 7 commits June 1, 2024 11:08

Added filter callback on dropdown menu

6fcc0e6

remove redundant code revert changes on `_enableFilter` variable fixes based on PR comments Update packages/flutter/test/material/dropdown_menu_test.dart

update filter test

7c861d9

simplify if clause with null operator

2640f72

assert enable filter if filter is not null

8041c09

Update packages/flutter/lib/src/material/dropdown_menu.dart

64bfb24

Co-authored-by: Qun Cheng <[email protected]>

update documentation

6634ebc

added test for filter callback assertion

32c5675

dacianf force-pushed the feature/add-filter-callback-on-dropdown branch from ceb5087 to 32c5675 Compare June 1, 2024 08:08

dacianf requested a review from justinmc June 2, 2024 19:23

justinmc approved these changes Jun 3, 2024

View reviewed changes

justinmc merged commit a92318d into flutter:master Jun 3, 2024
71 checks passed

engine-flutter-autoroll mentioned this pull request Jun 3, 2024

Roll Flutter from b295c86b2e85 to a92318dd9822 (56 revisions) flutter/packages#6858

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024

a92318d Added filter callback on dropdown menu (flutter/flutter#143939)

eeee013

engine-flutter-autoroll mentioned this pull request Jun 3, 2024

Roll Flutter from b295c86b2e85 to e02d29d52ed9 (57 revisions) flutter/packages#6859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024

a92318d Added filter callback on dropdown menu (flutter/flutter#143939)

ffaf4a6

engine-flutter-autoroll mentioned this pull request Jun 3, 2024

Manual roll Flutter from c85fa6abf4ff to 4cad9fde6791 (83 revisions) flutter/packages#6861

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024

a92318d Added filter callback on dropdown menu (flutter/flutter#143939)

1be8113

dacianf deleted the feature/add-filter-callback-on-dropdown branch June 4, 2024 07:22

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

a92318d Added filter callback on dropdown menu (flutter/flutter#143939)

09d5d0c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added filter callback on dropdown menu #143939

Added filter callback on dropdown menu #143939

dacianf commented Feb 22, 2024

flutter-dashboard bot commented Mar 31, 2024

dacianf commented Apr 12, 2024

QuncCccccc commented Apr 12, 2024

dacianf commented Apr 29, 2024

dacianf commented May 2, 2024

dacianf commented May 14, 2024

QuncCccccc left a comment

QuncCccccc commented May 30, 2024

dacianf commented May 31, 2024

QuncCccccc left a comment

dacianf commented May 31, 2024

justinmc left a comment

justinmc left a comment

justinmc Jun 3, 2024

Added filter callback on dropdown menu #143939

Added filter callback on dropdown menu #143939

Conversation

dacianf commented Feb 22, 2024

Pre-launch Checklist

flutter-dashboard bot commented Mar 31, 2024

dacianf commented Apr 12, 2024

QuncCccccc commented Apr 12, 2024

dacianf commented Apr 29, 2024

dacianf commented May 2, 2024

dacianf commented May 14, 2024

QuncCccccc left a comment

Choose a reason for hiding this comment

QuncCccccc commented May 30, 2024

dacianf commented May 31, 2024

QuncCccccc left a comment

Choose a reason for hiding this comment

dacianf commented May 31, 2024

justinmc left a comment

Choose a reason for hiding this comment

justinmc left a comment

Choose a reason for hiding this comment

justinmc Jun 3, 2024

Choose a reason for hiding this comment