Add test for animated_padding.0.dart API example. #146718

ksokolovskyi · 2024-04-13T12:34:04Z

This PR contributes to #130459

Description

Adds examples/api/test/widgets/implicit_animations/animated_padding.0_test.dart test

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

Renzo-Olivares · 2024-04-16T23:52:55Z

examples/api/test/widgets/implicit_animations/animated_padding.0_test.dart

+          matching: find.byType(Padding),
+        ),
+      );
+      expect(padding.padding, equals(const EdgeInsets.all(100)));


nit: prefer double literals 100 -> 100.0 https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#use-double-literals-for-double-constants .

Thanks for the review!
I fixed this nit in the latest commit

Renzo-Olivares

LGTM, thanks for the contribution!

ksokolovskyi · 2024-04-18T19:25:42Z

@Renzo-Olivares do you know what is wrong with Google testing? Why does it fail? And why the current one is already 2h 49m in progress?

Renzo-Olivares · 2024-04-18T21:19:39Z

@ksokolovskyi sorry about that, the failing tests look unrelated. Have you tried rebasing your branch to master?

ksokolovskyi · 2024-04-19T15:46:14Z

@Renzo-Olivares thanks for the suggestion. I have just rebased it. Let's wait =)

auto-submit · 2024-04-19T17:22:20Z

auto label is removed for flutter/flutter/146718, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

hannah-hyj

LGTM

ksokolovskyi · 2024-04-19T21:05:11Z

@Renzo-Olivares @Hangyujin thanks for the review!

…utter#146718)

flutter/flutter@98685a0...1a905d5 2024-04-21 [email protected] Roll Flutter Engine from 1c3f0f1f6500 to 75ca2195c936 (1 revision) (flutter/flutter#147136) 2024-04-21 [email protected] Roll Flutter Engine from 1e247ccaa911 to 1c3f0f1f6500 (1 revision) (flutter/flutter#147134) 2024-04-21 [email protected] Roll Flutter Engine from 1ac3ce3b4729 to 1e247ccaa911 (1 revision) (flutter/flutter#147128) 2024-04-21 [email protected] Roll Flutter Engine from 40110ec82d4b to 1ac3ce3b4729 (1 revision) (flutter/flutter#147125) 2024-04-20 [email protected] fixes some gesture not getting disposed (flutter/flutter#147112) 2024-04-20 [email protected] Roll Flutter Engine from d8a8f29612b6 to 40110ec82d4b (1 revision) (flutter/flutter#147114) 2024-04-20 [email protected] Roll Flutter Engine from 499eddab8451 to d8a8f29612b6 (2 revisions) (flutter/flutter#147108) 2024-04-20 [email protected] Roll Flutter Engine from 4d34b6d3da7d to 499eddab8451 (3 revisions) (flutter/flutter#147105) 2024-04-20 [email protected] Roll Flutter Engine from f22fb591870f to 4d34b6d3da7d (1 revision) (flutter/flutter#147104) 2024-04-20 [email protected] Roll Flutter Engine from 6f4d753ffddc to f22fb591870f (1 revision) (flutter/flutter#147101) 2024-04-20 [email protected] Roll Flutter Engine from 3db86b3cabec to 6f4d753ffddc (2 revisions) (flutter/flutter#147099) 2024-04-20 [email protected] Roll Flutter Engine from 55670b71eb00 to 3db86b3cabec (4 revisions) (flutter/flutter#147095) 2024-04-19 [email protected] Add Kostiantyn Sokolovskyi to the AUTHORS. (flutter/flutter#147065) 2024-04-19 [email protected] Roll Flutter Engine from a9a6f598f007 to 55670b71eb00 (1 revision) (flutter/flutter#147091) 2024-04-19 [email protected] Roll pub packages (flutter/flutter#147030) 2024-04-19 [email protected] Add tests for gesture_detector.0.dart and gesture_detector.1.dart API examples. (flutter/flutter#146724) 2024-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/flutter#147090) 2024-04-19 [email protected] [material] Fix info text (flutter/flutter#147040) 2024-04-19 [email protected] Roll Flutter Engine from 0902c4117ed9 to a9a6f598f007 (1 revision) (flutter/flutter#147088) 2024-04-19 [email protected] Roll Flutter Engine from 5083af669cee to 0902c4117ed9 (1 revision) (flutter/flutter#147085) 2024-04-19 [email protected] Add test for animated_padding.0.dart API example. (flutter/flutter#146718) 2024-04-19 [email protected] Refactor android preview tool integration tests (flutter/flutter#146518) 2024-04-19 [email protected] Roll Flutter Engine from 1363b52813e3 to 5083af669cee (1 revision) (flutter/flutter#147083) 2024-04-19 [email protected] Add test for dismissible.0.dart API example. (flutter/flutter#146723) 2024-04-19 [email protected] Roll Flutter Engine from 908f619d9e1c to 1363b52813e3 (4 revisions) (flutter/flutter#147079) 2024-04-19 [email protected] Update docs around ga3 ga4 mismatch (flutter/flutter#147075) 2024-04-19 [email protected] Add test for preferred_size.0.dart API example. (flutter/flutter#146725) 2024-04-19 [email protected] Roll Flutter Engine from 9cc1cc3de1a7 to 908f619d9e1c (1 revision) (flutter/flutter#147068) 2024-04-19 [email protected] Roll Flutter Engine from 7fafbbf17c02 to 9cc1cc3de1a7 (1 revision) (flutter/flutter#147061) 2024-04-19 [email protected] Roll Packages from 0e3809d to 88a3a56 (4 revisions) (flutter/flutter#147059) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR contributes to flutter#130459 ### Description - Adds `examples/api/test/widgets/implicit_animations/animated_padding.0_test.dart` test

flutter/flutter@98685a0...1a905d5 2024-04-21 [email protected] Roll Flutter Engine from 1c3f0f1f6500 to 75ca2195c936 (1 revision) (flutter/flutter#147136) 2024-04-21 [email protected] Roll Flutter Engine from 1e247ccaa911 to 1c3f0f1f6500 (1 revision) (flutter/flutter#147134) 2024-04-21 [email protected] Roll Flutter Engine from 1ac3ce3b4729 to 1e247ccaa911 (1 revision) (flutter/flutter#147128) 2024-04-21 [email protected] Roll Flutter Engine from 40110ec82d4b to 1ac3ce3b4729 (1 revision) (flutter/flutter#147125) 2024-04-20 [email protected] fixes some gesture not getting disposed (flutter/flutter#147112) 2024-04-20 [email protected] Roll Flutter Engine from d8a8f29612b6 to 40110ec82d4b (1 revision) (flutter/flutter#147114) 2024-04-20 [email protected] Roll Flutter Engine from 499eddab8451 to d8a8f29612b6 (2 revisions) (flutter/flutter#147108) 2024-04-20 [email protected] Roll Flutter Engine from 4d34b6d3da7d to 499eddab8451 (3 revisions) (flutter/flutter#147105) 2024-04-20 [email protected] Roll Flutter Engine from f22fb591870f to 4d34b6d3da7d (1 revision) (flutter/flutter#147104) 2024-04-20 [email protected] Roll Flutter Engine from 6f4d753ffddc to f22fb591870f (1 revision) (flutter/flutter#147101) 2024-04-20 [email protected] Roll Flutter Engine from 3db86b3cabec to 6f4d753ffddc (2 revisions) (flutter/flutter#147099) 2024-04-20 [email protected] Roll Flutter Engine from 55670b71eb00 to 3db86b3cabec (4 revisions) (flutter/flutter#147095) 2024-04-19 [email protected] Add Kostiantyn Sokolovskyi to the AUTHORS. (flutter/flutter#147065) 2024-04-19 [email protected] Roll Flutter Engine from a9a6f598f007 to 55670b71eb00 (1 revision) (flutter/flutter#147091) 2024-04-19 [email protected] Roll pub packages (flutter/flutter#147030) 2024-04-19 [email protected] Add tests for gesture_detector.0.dart and gesture_detector.1.dart API examples. (flutter/flutter#146724) 2024-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/flutter#147090) 2024-04-19 [email protected] [material] Fix info text (flutter/flutter#147040) 2024-04-19 [email protected] Roll Flutter Engine from 0902c4117ed9 to a9a6f598f007 (1 revision) (flutter/flutter#147088) 2024-04-19 [email protected] Roll Flutter Engine from 5083af669cee to 0902c4117ed9 (1 revision) (flutter/flutter#147085) 2024-04-19 [email protected] Add test for animated_padding.0.dart API example. (flutter/flutter#146718) 2024-04-19 [email protected] Refactor android preview tool integration tests (flutter/flutter#146518) 2024-04-19 [email protected] Roll Flutter Engine from 1363b52813e3 to 5083af669cee (1 revision) (flutter/flutter#147083) 2024-04-19 [email protected] Add test for dismissible.0.dart API example. (flutter/flutter#146723) 2024-04-19 [email protected] Roll Flutter Engine from 908f619d9e1c to 1363b52813e3 (4 revisions) (flutter/flutter#147079) 2024-04-19 [email protected] Update docs around ga3 ga4 mismatch (flutter/flutter#147075) 2024-04-19 [email protected] Add test for preferred_size.0.dart API example. (flutter/flutter#146725) 2024-04-19 [email protected] Roll Flutter Engine from 9cc1cc3de1a7 to 908f619d9e1c (1 revision) (flutter/flutter#147068) 2024-04-19 [email protected] Roll Flutter Engine from 7fafbbf17c02 to 9cc1cc3de1a7 (1 revision) (flutter/flutter#147061) 2024-04-19 [email protected] Roll Packages from 0e3809d to 88a3a56 (4 revisions) (flutter/flutter#147059) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 13, 2024

Renzo-Olivares reviewed Apr 16, 2024

View reviewed changes

Renzo-Olivares approved these changes Apr 16, 2024

View reviewed changes

ksokolovskyi added 2 commits April 19, 2024 17:43

Add test for animated_padding.0.dart API example.

1594d1b

Double literal fix

32079ae

ksokolovskyi force-pushed the add-animated-padding-example-tests branch from efda1d2 to 32079ae Compare April 19, 2024 15:43

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2024

hannah-hyj approved these changes Apr 19, 2024

View reviewed changes

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2024

auto-submit bot merged commit a4e9026 into flutter:master Apr 19, 2024
141 checks passed

engine-flutter-autoroll mentioned this pull request Apr 20, 2024

Roll Flutter from 98685a099fdd to 28675753ff57 (25 revisions) flutter/packages#6581

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2024

a4e9026 Add test for animated_padding.0.dart API example. (flutter/fl…

d25bc3c

…utter#146718)

engine-flutter-autoroll mentioned this pull request Apr 20, 2024

Roll Flutter from 98685a099fdd to 158a9a81774c (26 revisions) flutter/packages#6582

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2024

a4e9026 Add test for animated_padding.0.dart API example. (flutter/fl…

f459860

…utter#146718)

engine-flutter-autoroll mentioned this pull request Apr 21, 2024

Roll Flutter from 98685a099fdd to 1a905d508de1 (30 revisions) flutter/packages#6583

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2024

a4e9026 Add test for animated_padding.0.dart API example. (flutter/fl…

3522962

…utter#146718)

HansMuller mentioned this pull request Apr 26, 2024

Flutter Framework Team: Notable Commits #121415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add test for animated_padding.0.dart API example. #146718

Add test for animated_padding.0.dart API example. #146718

Uh oh!

ksokolovskyi commented Apr 13, 2024 •

edited

Loading

Uh oh!

Renzo-Olivares Apr 16, 2024

Uh oh!

ksokolovskyi Apr 17, 2024

Uh oh!

Renzo-Olivares left a comment

Uh oh!

ksokolovskyi commented Apr 18, 2024

Uh oh!

Renzo-Olivares commented Apr 18, 2024

Uh oh!

ksokolovskyi commented Apr 19, 2024

Uh oh!

auto-submit bot commented Apr 19, 2024

Uh oh!

hannah-hyj left a comment

Uh oh!

Uh oh!

ksokolovskyi commented Apr 19, 2024

Uh oh!

Uh oh!

Add test for animated_padding.0.dart API example. #146718

Add test for animated_padding.0.dart API example. #146718

Uh oh!

Conversation

ksokolovskyi commented Apr 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pre-launch Checklist

Uh oh!

Renzo-Olivares Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi commented Apr 18, 2024

Uh oh!

Renzo-Olivares commented Apr 18, 2024

Uh oh!

ksokolovskyi commented Apr 19, 2024

Uh oh!

auto-submit bot commented Apr 19, 2024

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ksokolovskyi commented Apr 19, 2024

Uh oh!

Uh oh!

ksokolovskyi commented Apr 13, 2024 •

edited

Loading