Skip to content

[tool] Fix stdin.flush calls on processes started by FakeProcessManager #151183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2024
Merged

[tool] Fix stdin.flush calls on processes started by FakeProcessManager #151183

merged 2 commits into from
Jul 2, 2024

Conversation

andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Jul 2, 2024 •
edited
Loading

Fixes #151151

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@andrewkolos andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 2, 2024
@andrewkolos andrewkolos marked this pull request as ready for review July 2, 2024 19:17
christopherfujino
christopherfujino approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 2, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jul 2, 2024

auto label is removed for flutter/flutter/151183, due to - The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 2, 2024
@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 2, 2024
@auto-submit auto-submit bot merged commit 8acf86d into flutter:master Jul 2, 2024
130 checks passed
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request Jul 3, 2024
@hello-coder-xu
Merge branch 'master' into fix/pageController_get_value_error
8798d1a 
* master: (88 commits)
  Fix scheduler event loop being stuck due to task with Priority.idle (flutter#151168)
  Fix result propagation in RenderSliverEdgeInsetsPadding.hitTestChildren (flutter#149825)
  docImports for flutter_test (flutter#151189)
  Interactable ScrollView content when settling a scroll activity (flutter#145848)
  [flutter_tools] Update the mapping for the Dart SDK internal URI (flutter#151170)
  Roll pub packages (flutter#151129)
  Fix typo (flutter#151192)
  [tool] Fix `stdin.flush` calls on processes started by `FakeProcessManager` (flutter#151183)
  Roll Flutter Engine from 433d360eee11 to 44278941443e (4 revisions) (flutter#151186)
  Use `ErrorHandlingFileSystem.deleteIfExists` when deleting .plugin_symlinks (flutter#151073)
  ScrollEndNotification example: auto-scroll based on RenderSliver constraints and geometry (flutter#143538)
  Roll Packages from 412ec46 to d2705fb (13 revisions) (flutter#151169)
  docimports for painting (flutter#151143)
  docimports for scheduler (flutter#151126)
  `dismissible.dart` code cleanup (flutter#150276)
  docimports for physics (flutter#151125)
  docimports for services (flutter#151134)
  docimports for cupertino (flutter#151149)
  docimports for gestures (flutter#151123)
  Docimports for foundation (flutter#151119)
  ...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
428ac41 
…rocessManager` (flutter/flutter#151183)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
081dc4f 
…rocessManager` (flutter/flutter#151183)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
dab02f5 
…rocessManager` (flutter/flutter#151183)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
39f29f3 
…rocessManager` (flutter/flutter#151183)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
71a270a 
…rocessManager` (flutter/flutter#151183)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
4fc6af3 
…rocessManager` (flutter/flutter#151183)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
ee8f324 
…rocessManager` (flutter/flutter#151183)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
5769de6 
…rocessManager` (flutter/flutter#151183)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
42e7bda 
…rocessManager` (flutter/flutter#151183)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 7, 2024
@engine-flutter-autoroll
Roll Flutter from af913a7 to fafd67d34d68 (41 revisions) (#7062)
e1bf479 
Roll Flutter from af913a7 to fafd67d34d68 (41 revisions)

flutter/flutter@af913a7...fafd67d

2024-07-05 [email protected] Roll Flutter Engine from 74d40c160e48 to 4ee09d3b7f3b (1 revision) (flutter/flutter#151346)
2024-07-05 [email protected] Roll Flutter Engine from ba9c7b6336ef to 74d40c160e48 (1 revision) (flutter/flutter#151340)
2024-07-05 [email protected] Roll Flutter Engine from 1f0f950ea02a to ba9c7b6336ef (1 revision) (flutter/flutter#151331)
2024-07-05 [email protected] Roll Flutter Engine from 3c6a373bda3e to 1f0f950ea02a (1 revision) (flutter/flutter#151326)
2024-07-04 [email protected] Roll Flutter Engine from 79a91e38c587 to 3c6a373bda3e (2 revisions) (flutter/flutter#151318)
2024-07-04 [email protected] Roll Packages from d2705fb to 754de19 (3 revisions) (flutter/flutter#151315)
2024-07-04 [email protected] Roll Flutter Engine from 2b6bb516e7e6 to 79a91e38c587 (2 revisions) (flutter/flutter#151314)
2024-07-04 [email protected] Roll Flutter Engine from 8e2d05fa95d7 to 2b6bb516e7e6 (2 revisions) (flutter/flutter#151299)
2024-07-04 [email protected] Roll Flutter Engine from 4190543cb093 to 8e2d05fa95d7 (13 revisions) (flutter/flutter#151293)
2024-07-03 [email protected] Roll pub packages (flutter/flutter#151203)
2024-07-03 [email protected] Fix invalid URL suggestion for gradle incompatability (flutter/flutter#150999)
2024-07-03 [email protected] Cupertino transparent navigation bars (flutter/flutter#149102)
2024-07-03 [email protected] Prepares semantics_update_test for upcoming link URL change (flutter/flutter#151261)
2024-07-03 [email protected] Add a message about spam/brigading (flutter/flutter#150583)
2024-07-03 [email protected] PinnedHeaderSliver example based on the iOS Settings AppBar (flutter/flutter#151205)
2024-07-03 [email protected] Update deprecation policy (flutter/flutter#151257)
2024-07-03 [email protected] SliverFloatingHeader (flutter/flutter#151145)
2024-07-03 [email protected] Remove warning when KGP version not detected (flutter/flutter#151254)
2024-07-03 [email protected] Feat: Add withOpacity to gradient (flutter/flutter#150670)
2024-07-03 [email protected] Fix references in examples (flutter/flutter#151204)
2024-07-03 [email protected] Fix link in tree hygene doc (flutter/flutter#151235)
2024-07-03 [email protected] content dimensions are not established get controller value error (flutter/flutter#148938)
2024-07-03 [email protected] chore: fix typos and link broken (flutter/flutter#150402)
2024-07-03 [email protected] Add example of goldenFileComparator usage in widget tests (flutter/flutter#150422)
2024-07-03 [email protected] Fix project name fallback (flutter/flutter#150614)
2024-07-03 [email protected] Roll Flutter Engine from a3e61c0fd1c2 to 4190543cb093 (1 revision) (flutter/flutter#151241)
2024-07-03 [email protected] Roll Flutter Engine from 8274f54f11be to a3e61c0fd1c2 (2 revisions) (flutter/flutter#151237)
2024-07-03 [email protected] Force regeneration of platform-specific manifests before running performance tests (flutter/flutter#151003)
2024-07-03 [email protected] Handle a SocketException thrown when sending the browser close command to Chrome (flutter/flutter#151197)
2024-07-03 [email protected] Roll Flutter Engine from a02e3f673da3 to 8274f54f11be (4 revisions) (flutter/flutter#151226)
2024-07-03 [email protected] Roll Flutter Engine from c5c0c54d6d1d to a02e3f673da3 (1 revision) (flutter/flutter#151212)
2024-07-03 [email protected] Roll Flutter Engine from 44278941443e to c5c0c54d6d1d (9 revisions) (flutter/flutter#151208)
2024-07-02 [email protected] Fix scheduler event loop being stuck due to task with Priority.idle (flutter/flutter#151168)
2024-07-02 [email protected] Fix result propagation in RenderSliverEdgeInsetsPadding.hitTestChildren (flutter/flutter#149825)
2024-07-02 [email protected] docImports for flutter_test (flutter/flutter#151189)
2024-07-02 [email protected] Interactable ScrollView content when settling a scroll activity (flutter/flutter#145848)
2024-07-02 [email protected] [flutter_tools] Update the mapping for the Dart SDK internal URI (flutter/flutter#151170)
2024-07-02 [email protected] Roll pub packages (flutter/flutter#151129)
2024-07-02 [email protected] Fix typo (flutter/flutter#151192)
2024-07-02 [email protected] [tool] Fix `stdin.flush` calls on processes started by `FakeProcessManager` (flutter/flutter#151183)
2024-07-02 [email protected] Roll Flutter Engine from 433d360eee11 to 44278941443e (4 revisions) (flutter/flutter#151186)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
...
TahaTesser pushed a commit to TahaTesser/flutter that referenced this pull request Jul 8, 2024
@andrewkolos @TahaTesser
[tool] Fix stdin.flush calls on processes started by `FakeProcessMa…
a54a389 
…nager` (flutter#151183)

Fixes flutter#151151
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jul 8, 2024
@andrewkolos @victorsanni
[tool] Fix stdin.flush calls on processes started by `FakeProcessMa…
4dbb539 
…nager` (flutter#151183)

Fixes flutter#151151
@andrewkolos andrewkolos mentioned this pull request Jul 21, 2024
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
8acf86d [tool] Fix stdin.flush calls on processes started by `FakeP…
31ddb4f 
…rocessManager` (flutter/flutter#151183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tool] stdin.flush calls on processes started by FakeProcessManager never complete
2 participants
@andrewkolos @christopherfujino