Semantics for CupertinoTabBar #19924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ], | ||
| child: new Semantics( | ||
| selected: active, | ||
| hint: 'tab, ${index + 1} of ${items.length}', |
There was a problem hiding this comment.
This string would need to be localized, I would leave it out for now
There was a problem hiding this comment.
We'd have to do #13452 first
goderbauer
reviewed
Jul 27, 2018
| ], | ||
| child: new Semantics( | ||
| selected: active, | ||
| hint: 'tab, ${index + 1} of ${items.length}', |
There was a problem hiding this comment.
What about localization? We have a localized string for this in the MaterialLocalizations, not sure if that one can be reused here?
There was a problem hiding this comment.
We can't import package material. We'd have to solve #13452 first
There was a problem hiding this comment.
Understood. Can you add a TODO here to remind us that this needs localization?
xster
force-pushed
the
tabbar-accessibility
branch
from
a83187b to
7d8d673
Compare
xster
force-pushed
the
tabbar-accessibility
branch
from
7d8d673 to
7107fad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19921