Skip to content

Complete the dartdoc for servics.dart #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Conversation

abarth
Copy link
Contributor

@abarth abarth commented Jun 4, 2016

Also, add more dartdoc to widgets.dart.

@abarth
Copy link
Contributor Author

abarth commented Jun 4, 2016

@Hixie

@abarth abarth force-pushed the doc_services branch 5 times, most recently from 2784c3e to 32ea4e4 Compare June 6, 2016 03:47
@abarth
Copy link
Contributor Author

abarth commented Jun 6, 2016

433 public members lack documentation

/// Creates an image resource.
///
/// The image resource awaits the given [Future]. When the future resolves,
/// it notifies the [ImageListener] that have been registered with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that has

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or [ImageListener]s

@@ -47,9 +47,11 @@ class _GridPaperPainter extends CustomPainter {
bool hitTest(Point position) => false;
}

/// Draws a rectalinear grid of 1px width lines at the specified color and interval.
/// Useful with a Stack for visualizing your layout along a grid.
/// A widget that draws a rectalinear grid of 1px wide lines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rectilinear

@Hixie
Copy link
Contributor

Hixie commented Jun 6, 2016

LGTM

Also, add more dartdoc to widgets.dart.
@abarth abarth merged commit d9916bb into flutter:master Jun 6, 2016
@abarth abarth deleted the doc_services branch June 6, 2016 06:58
cdotstout pushed a commit to cdotstout/flutter that referenced this pull request Apr 3, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants