Trivial improvement of AbstractNode docs. #7399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Jan 9, 2017
| /// | ||
| /// When this becomes true, [attach] is called. | ||
| /// | ||
| /// When this becomes false, [detach] is called. |
There was a problem hiding this comment.
We should be clear about which happens first.
|
LGTM, but I think the value is a result of the call (in the base class), not something that preceeds the call. |
This confused me briefly the other day.
|
Updated with more precise wording, will check in on green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This confused me briefly the other day.