Change Flexible's default FlexFit
#7404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jan 10, 2017
| @@ -2229,17 +2229,27 @@ class Column extends Flex { | |||
|
|
|||
| /// A widget that controls how a child of a [Row], [Column], or [Flex] flexes. | |||
| /// | |||
| /// Using a [Flexible] widget to gives a child of a [Row], [Column], or [Flex] | |||
Hixie
reviewed
Jan 10, 2017
| @@ -2298,9 +2308,13 @@ class Flexible extends ParentDataWidget<Flex> { | |||
| /// the available space is divided amoung them according to the [flex] factor. | |||
There was a problem hiding this comment.
s/Using/Use/ or s/to make/makes/.
|
I'm a little concerned that flipping the default broke no tests, but, LGTM! |
I did a previous CL where I migrated everyone to |
Previously, `Flexible` defaulted to `FlexFit.tight`, which forced the child to expand to fill the available space. Now, `Flexible` defaults to `FlexFit.loose`, which does not force the child to expand to fill the available space. If you want the child to expand to fill the available space, consider using `Expanded` instead. Fixes flutter#5169
abarth
force-pushed
the
change_flexible
branch
from
558b3f5 to
5353a26
Compare
|
Sure but that means there was no test verifying that not giving any arguments to Flexible meant it was treated like Expanded. Or vice versa now. :-) |
|
There were previously, but I guess I removed them when I migrated them to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Flexibledefaulted toFlexFit.tight, which forced the child toexpand to fill the available space. Now,
Flexibledefaults toFlexFit.loose, which does not force the child to expand to fill the availablespace.
If you want the child to expand to fill the available space, consider using
Expandedinstead.Fixes #5169