Skip to content

Add example IntelliJ metadata (flutter-intellij#607). #7428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2017
Merged

Conversation

pq
Copy link
Contributor

@pq pq commented Jan 10, 2017

Ensures example projects open cleanly out-of-the-box w/ the Flutter Plugin.

See: flutter/flutter-intellij#607.

@devoncarew

Ensures example projects open cleanly out-of-the-box w/ the Flutter Plugin.

See: flutter/flutter-intellij#607.
@devoncarew
Copy link
Member

The .idea/modules.xml files look good.

Shouldn't the project foo.iml files be at the root of each project directory (not in the .idea subdirectory)?

@pq
Copy link
Contributor Author

pq commented Jan 10, 2017

Shouldn't the project foo.iml files be at the root of each project directory (not in the .idea subdirectory)?

I have no idea to be honest. This is where they were put when I added the Flutter Module type (via the inspection) and it appears to work. Removing them did not.

@devoncarew
Copy link
Member

I think that the foo.iml file is generally at the project root - something like:

my_project/.idea/modules.xml
my_project/my_project.iml

@devoncarew
Copy link
Member

We'll probably want to follow that example for hello_world, layers, and stocks (I think flutter_gallery already is).

@pq
Copy link
Contributor Author

pq commented Jan 10, 2017

We'll probably want to follow that example for hello_world, layers, and stocks (I think flutter_gallery already is).

Where is that example from? I just let IntelliJ create the files for me and this where they went... Not a lot of the skin in the game. Just curious!

@mit-mit
Copy link
Member

mit-mit commented Jan 11, 2017

If I create a new project, the .iml file is a sibling of the .idea so would be good to be consistent with that.

@pq
Copy link
Contributor Author

pq commented Jan 11, 2017

Interestingly the New Project flow chooses a different location (the root) than adding a Flutter Module type (the .idea dir) as per the inspection. I'll take a look at the inspection and see what's up there...

In the meantime, this should be more what you're after.

PTAL.

@devoncarew

@devoncarew
Copy link
Member

lgtm! thanks for the updates

@pq pq merged commit a8cd212 into flutter:master Jan 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants