Skip to content

Fix typos #92245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

Fix typos #92245

merged 1 commit into from
Oct 21, 2021

Conversation

asashour
Copy link
Contributor

This fixes some extra the

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 21, 2021
@google-cla google-cla bot added the cla: yes label Oct 21, 2021
@TahaTesser TahaTesser self-requested a review October 21, 2021 10:05
@TahaTesser TahaTesser requested a review from Hixie October 21, 2021 10:06
@TahaTesser
Copy link
Member

LGTM, you need to get test exemption from @Hixie

@Hixie
Copy link
Contributor

Hixie commented Oct 21, 2021

test-exempt: only affects comments

@fluttergithubbot fluttergithubbot merged commit e7c809e into flutter:master Oct 21, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@asashour @clocksmith
Fix typos (flutter#92245)
2121844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asashour @TahaTesser @Hixie @fluttergithubbot