Skip to content

[pigeon] Update auto-formatting #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

stuartmorgan-g
Copy link
Contributor

New tests were added to Pigeon between the clang-format change PR
running tests and landing, so format broke the tree in post-submit due
to the new file not having the updated formatting.

Fixes the tree.

No version change: Formatting only; does not affect clients.
No CHANGELOG change: Uninteresting mechanical change.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

New tests were added to Pigeon between the clang-format change PR
running tests and landing, so `format` broke the tree in post-submit due
to the new file not having the updated formatting.

Fixes the tree.
@stuartmorgan-g
Copy link
Contributor Author

Landing on red to fix the tree.

@stuartmorgan-g stuartmorgan-g merged commit b279959 into flutter:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants