[ci] Enable the all_packages tasks #2724
Conversation
Adds the "build all packages together" tasks on all platforms. While doing it on every platform isn't necessary for non-plugin packages, this is part of pre-alignment with flutter/plugins in preparation for the move. This is a light-weight task, so adding it in advance should not cause significant overhead. The command name and the output directory are still plugin-centric, which is why the naming is sometimes "all packages" (everywhere the name is part of a CI specification) and "all plugins" (when it's the tool command or the directory created by the tool). The naming will be cleaned up later; using the final task names now avoids task name confusion (despite the name it builds all packages) and later churn in tasks (especially LUCI where name changes require a `bringup` cycle). Part of flutter/flutter#113764
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -268,6 +307,23 @@ task: | |||
| << : *FLUTTER_UPGRADE_TEMPLATE | |||
| << : *MACOS_ARM_TEMPLATE | |||
| matrix: | |||
| - name: macos-custom_package_tests | |||
There was a problem hiding this comment.
The weird diff here and below is because I noticed that I had accidentally put this in the "iOS tasks" group when I added groups to this file, but we don't actually know what the target platform(s) is/are for custom test scripts because they can do anything.
Renames `all-plugins-app` to `create-all-packages-app`, to make it clear that it's not plugin-specific (in preparation for the repo merge). See flutter/packages#2724 for context.
|
test-exempt: configuration |
stuartmorgan-g
added
the
autosubmit
Adds the "build all packages together" tasks on all platforms. While doing it on every platform isn't necessary for non-plugin packages, this is part of pre-alignment with flutter/plugins in preparation for the move. This is a light-weight task, so adding it in advance should not cause significant overhead.
(Windows is in bringup mode, as required for new LUCI targets.)
The command name and the output directory are still plugin-centric, which is why the naming is sometimes "all packages" (everywhere the name is part of a CI specification) and "all plugins" (when it's the tool command or the directory created by the tool). The naming will be cleaned up later; using the final task names now avoids task name confusion (despite the name it builds all packages) and later churn in tasks (especially LUCI where name changes require a
bringupcycle).Part of flutter/flutter#113764
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).