Skip to content

[ci] Update legacy Flutter version tests #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

stuartmorgan-g
Copy link
Contributor

Updates the N-1 and N-2 version tests to 3.0 and 3.3 now that 3.7 is on stable.

Updates all packages to require at least Flutter 3.0 since we won't be testing earlier versions at all.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛥️ LGTM!

@@ -6,7 +6,7 @@ version: 1.1.1

environment:
sdk: '>=2.12.0 <3.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the higher bound for the sdk in these as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or set to <4.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a separate PR, both since it's unrelated to this change and would affect more packages.

It's also still not clear to me if that's correct to do yet.

@ditman
Copy link
Member

ditman commented Jan 24, 2023

�[31m  css_colors:
    Missing version change�[0m
�[31m  extension_google_sign_in_as_googleapis_auth:
    Missing version change�[0m
�[31m  pointer_interceptor:
    Missing version change�[0m

Needs versioning override?

@stuartmorgan-g stuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label Jan 24, 2023
@stuartmorgan-g
Copy link
Contributor Author

No version change since we don't want to release this, only for it to apply to the next release.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023
@auto-submit auto-submit bot merged commit c72e3f2 into flutter:main Jan 24, 2023
@stuartmorgan-g stuartmorgan-g deleted the stable-3-7-update-n-2 branch January 24, 2023 23:57
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 30, 2023
* main: (479 commits)
  removes raw ArrayLists (flutter#3101)
  Roll Flutter from c9affdb to 27f8ebd (15 revisions) (flutter#3098)
  [ci] Fix the new LUCI iOS build-all tasks (flutter#3099)
  [pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100)
  [pigeon] Swift host error handling (flutter#3084)
  Roll Flutter from a815ee6 to c9affdb (23 revisions) (flutter#3093)
  [ci] Enable min SDK version checks (flutter#3095)
  [pigeon] Fix C++ config handling (flutter#3094)
  [ci] Add LUCI version of iOS build-all (flutter#3096)
  [pigeon] Adds SwiftFunction annotation (flutter#2304)
  [flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088)
  [pigeon] requires analyzer 5.2.0 (flutter#3090)
  Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#3089)
  [ci] Update legacy Flutter version tests (flutter#3087)
  Roll Flutter (stable) from 135454af3247 to b06b8b271095 (2551 revisions) (flutter#3086)
  [flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080)
  Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#3085)
  [pigeon] Minor C++ output adjustments (flutter#3083)
  [pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081)
  Roll Flutter from f33e8d3 to bd7bee0 (5 revisions) (flutter#3082)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: css_colors p: dynamic_layouts The dynamic_layouts package p: extension_google_sign_in_as_googleapis_auth p: flutter_markdown p: pigeon p: pointer_interceptor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants