Skip to content

[pigeon] Fix C++ config handling #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pigeon/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 7.1.1

* [c++] Fixes handling of the `cpp*` options in `@ConfigurePigeon` annotations.

## 7.1.0

* Adds `@SwiftFunction` annotation for specifying custom swift function signature.
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/lib/generator_tools.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import 'ast.dart';
/// The current version of pigeon.
///
/// This must match the version in pubspec.yaml.
const String pigeonVersion = '7.1.0';
const String pigeonVersion = '7.1.1';

/// Read all the content from [stdin] to a String.
String readStdin() {
Expand Down
15 changes: 7 additions & 8 deletions packages/pigeon/lib/pigeon_lib.dart
Original file line number Diff line number Diff line change
Expand Up @@ -274,11 +274,10 @@ class PigeonOptions {
kotlinOptions: map.containsKey('kotlinOptions')
? KotlinOptions.fromMap(map['kotlinOptions']! as Map<String, Object>)
: null,
cppHeaderOut: map['experimental_cppHeaderOut'] as String?,
cppSourceOut: map['experimental_cppSourceOut'] as String?,
cppOptions: map.containsKey('experimental_cppOptions')
? CppOptions.fromMap(
map['experimental_cppOptions']! as Map<String, Object>)
cppHeaderOut: map['cppHeaderOut'] as String?,
cppSourceOut: map['cppSourceOut'] as String?,
cppOptions: map.containsKey('cppOptions')
? CppOptions.fromMap(map['cppOptions']! as Map<String, Object>)
: null,
dartOptions: map.containsKey('dartOptions')
? DartOptions.fromMap(map['dartOptions']! as Map<String, Object>)
Expand Down Expand Up @@ -306,9 +305,9 @@ class PigeonOptions {
if (swiftOptions != null) 'swiftOptions': swiftOptions!.toMap(),
if (kotlinOut != null) 'kotlinOut': kotlinOut!,
if (kotlinOptions != null) 'kotlinOptions': kotlinOptions!.toMap(),
if (cppHeaderOut != null) 'experimental_cppHeaderOut': cppHeaderOut!,
if (cppSourceOut != null) 'experimental_cppSourceOut': cppSourceOut!,
if (cppOptions != null) 'experimental_cppOptions': cppOptions!.toMap(),
if (cppHeaderOut != null) 'cppHeaderOut': cppHeaderOut!,
if (cppSourceOut != null) 'cppSourceOut': cppSourceOut!,
if (cppOptions != null) 'cppOptions': cppOptions!.toMap(),
if (dartOptions != null) 'dartOptions': dartOptions!.toMap(),
if (copyrightHeader != null) 'copyrightHeader': copyrightHeader!,
if (astOut != null) 'astOut': astOut!,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon

package com.example.alternate_language_test_plugin;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon

#import <Foundation/Foundation.h>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon

#import "CoreTests.gen.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon
// ignore_for_file: public_member_api_docs, non_constant_identifier_names, avoid_as, unused_import, unnecessary_parenthesis, prefer_null_aware_operators, omit_local_variable_types, unused_shown_name, unnecessary_import

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
//
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon

package com.example.test_plugin
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
//
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon

import Foundation
Expand Down Expand Up @@ -110,23 +110,23 @@ struct AllNullableTypes {
var aNullableString: String? = nil

static func fromList(_ list: [Any?]) -> AllNullableTypes? {
let aNullableBool = list[0] as? Bool
let aNullableInt = list[1] as? Int32
let aNullableDouble = list[2] as? Double
let aNullableByteArray = list[3] as? FlutterStandardTypedData
let aNullable4ByteArray = list[4] as? FlutterStandardTypedData
let aNullable8ByteArray = list[5] as? FlutterStandardTypedData
let aNullableFloatArray = list[6] as? FlutterStandardTypedData
let aNullableList = list[7] as? [Any?]
let aNullableMap = list[8] as? [AnyHashable: Any?]
let nullableNestedList = list[9] as? [[Bool?]?]
let nullableMapWithAnnotations = list[10] as? [String?: String?]
let nullableMapWithObject = list[11] as? [String?: Any?]
let aNullableBool = list[0] as? Bool
let aNullableInt = list[1] as? Int32
let aNullableDouble = list[2] as? Double
let aNullableByteArray = list[3] as? FlutterStandardTypedData
let aNullable4ByteArray = list[4] as? FlutterStandardTypedData
let aNullable8ByteArray = list[5] as? FlutterStandardTypedData
let aNullableFloatArray = list[6] as? FlutterStandardTypedData
let aNullableList = list[7] as? [Any?]
let aNullableMap = list[8] as? [AnyHashable: Any?]
let nullableNestedList = list[9] as? [[Bool?]?]
let nullableMapWithAnnotations = list[10] as? [String?: String?]
let nullableMapWithObject = list[11] as? [String?: Any?]
var aNullableEnum: AnEnum? = nil
if let aNullableEnumRawValue = list[12] as? Int {
aNullableEnum = AnEnum(rawValue: aNullableEnumRawValue)
}
let aNullableString = list[13] as? String
let aNullableString = list[13] as? String

return AllNullableTypes(
aNullableBool: aNullableBool,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
//
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon

import Foundation
Expand Down Expand Up @@ -110,23 +110,23 @@ struct AllNullableTypes {
var aNullableString: String? = nil

static func fromList(_ list: [Any?]) -> AllNullableTypes? {
let aNullableBool = list[0] as? Bool
let aNullableInt = list[1] as? Int32
let aNullableDouble = list[2] as? Double
let aNullableByteArray = list[3] as? FlutterStandardTypedData
let aNullable4ByteArray = list[4] as? FlutterStandardTypedData
let aNullable8ByteArray = list[5] as? FlutterStandardTypedData
let aNullableFloatArray = list[6] as? FlutterStandardTypedData
let aNullableList = list[7] as? [Any?]
let aNullableMap = list[8] as? [AnyHashable: Any?]
let nullableNestedList = list[9] as? [[Bool?]?]
let nullableMapWithAnnotations = list[10] as? [String?: String?]
let nullableMapWithObject = list[11] as? [String?: Any?]
let aNullableBool = list[0] as? Bool
let aNullableInt = list[1] as? Int32
let aNullableDouble = list[2] as? Double
let aNullableByteArray = list[3] as? FlutterStandardTypedData
let aNullable4ByteArray = list[4] as? FlutterStandardTypedData
let aNullable8ByteArray = list[5] as? FlutterStandardTypedData
let aNullableFloatArray = list[6] as? FlutterStandardTypedData
let aNullableList = list[7] as? [Any?]
let aNullableMap = list[8] as? [AnyHashable: Any?]
let nullableNestedList = list[9] as? [[Bool?]?]
let nullableMapWithAnnotations = list[10] as? [String?: String?]
let nullableMapWithObject = list[11] as? [String?: Any?]
var aNullableEnum: AnEnum? = nil
if let aNullableEnumRawValue = list[12] as? Int {
aNullableEnum = AnEnum(rawValue: aNullableEnumRawValue)
}
let aNullableString = list[13] as? String
let aNullableString = list[13] as? String

return AllNullableTypes(
aNullableBool: aNullableBool,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon

#undef _HAS_EXCEPTIONS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Autogenerated from Pigeon (v7.1.0), do not edit directly.
// Autogenerated from Pigeon (v7.1.1), do not edit directly.
// See also: https://pub.dev/packages/pigeon

#ifndef PIGEON_CORE_TESTS_GEN_H_
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pigeon
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
repository: https://github.com/flutter/packages/tree/main/packages/pigeon
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3Apigeon
version: 7.1.0 # This must match the version in lib/generator_tools.dart
version: 7.1.1 # This must match the version in lib/generator_tools.dart

environment:
sdk: ">=2.12.0 <3.0.0"
Expand Down