Skip to content

[various] Prep for more const widgets #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023
Merged

[various] Prep for more const widgets #3139

merged 2 commits into from
Feb 1, 2023

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 1, 2023

Similar to flutter/plugins#7074.

flutter/flutter#119673 will make a few more widgets const. This prepares the plugins repo for that change.

I chose to ignore the resulting lint for now to ensure that the plugins continue to work on older versions of Flutter. Once the change referenced above is part of the oldest Flutter version supported by the plugins, we can resolve the TODO, remove the ignore, and make the widgets in question const.

@goderbauer goderbauer requested a review from Hixie as a code owner February 1, 2023 17:54
@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Feb 1, 2023
@goderbauer
Copy link
Member Author

Looks like I missed some packages. Putting this into draft until I have that resolved.

@goderbauer goderbauer marked this pull request as draft February 1, 2023 18:00
@goderbauer goderbauer changed the title [rfw] Prep for more const widgets [various] Prep for more const widgets Feb 1, 2023
@goderbauer goderbauer marked this pull request as ready for review February 1, 2023 18:08
@goderbauer
Copy link
Member Author

Alright, I got them all now. @stuartmorgan This one is ready for review now.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Feb 1, 2023
@stuartmorgan-g
Copy link
Contributor

Overrides: lint ignores are dev-only.

@goderbauer
Copy link
Member Author

Not sure what to do about the readme_excerpts failure. When I run the `update-excerpts command locally I am getting an error:

dart pub global run flutter_plugin_tools update-excerpts --packages flutter_adaptive_scaffold                                                                                moreconst

============================================================
|| Running for packages/flutter_adaptive_scaffold
============================================================

Running command: "dart pub get" in /Users/goderbauer/dev/packages/packages/flutter_adaptive_scaffold/example
Resolving dependencies...
Because flutter_adaptive_scaffold_example depends on code_excerpter from path which doesn't exist (could not find package code_excerpter at "../../../site-shared/packages/code_excerpter"), version solving failed.


The following packages had errors:
  packages/flutter_adaptive_scaffold:
    Unable to get script dependencies
See above for full details.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2023
@auto-submit auto-submit bot merged commit e63f3e3 into flutter:main Feb 1, 2023
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
* [various] Prep for more const widgets

* exclude from readme
@goderbauer goderbauer deleted the moreconst branch March 3, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: flutter_adaptive_scaffold p: flutter_markdown p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants