-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[various] Prep for more const widgets #3139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like I missed some packages. Putting this into draft until I have that resolved. |
Alright, I got them all now. @stuartmorgan This one is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Overrides: lint ignores are dev-only. |
Not sure what to do about the
|
* [various] Prep for more const widgets * exclude from readme
Similar to flutter/plugins#7074.
flutter/flutter#119673 will make a few more widgets const. This prepares the plugins repo for that change.
I chose to ignore the resulting lint for now to ensure that the plugins continue to work on older versions of Flutter. Once the change referenced above is part of the oldest Flutter version supported by the plugins, we can resolve the TODO, remove the ignore, and make the widgets in question const.