Skip to content

[camera_android]: Fixes crash when record video on Android versions lower than 12 #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 21, 2023
Merged

[camera_android]: Fixes crash when record video on Android versions lower than 12 #4635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
554f2ab
fix incorrect declaration EncoderProfiles when SDK is lower than 31
raulsvilar Aug 2, 2023
532c9e5
update CHANGELOG.md
raulsvilar Aug 2, 2023
f38efa4
update pubspec.yaml
raulsvilar Aug 2, 2023
6b79899
Merge branch 'main' of https://github.com/flutter/packages
raulsvilar Aug 14, 2023
ab5e9e2
Merge branch 'main' into main
raulsvilar Aug 16, 2023
86250f9
Merge branch 'main' into main
raulsvilar Aug 16, 2023
3f04c8a
Merge branch 'main' into main
raulsvilar Aug 18, 2023
2296c10
fix: change the version number
raulsvilar Aug 18, 2023
087eb96
Merge branch 'main' into main
raulsvilar Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/camera/camera_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT
## 0.10.8+7

* Fixes video record crash on Android versions lower than 12.
* Updates minimum supported SDK version to Flutter 3.7/Dart 2.19.

## 0.10.8+6
Expand Down
5 changes: 2 additions & 3 deletions packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,8 @@ private void prepareMediaRecorder(String outputFilePath) throws IOException {

// TODO(camsim99): Revert changes that allow legacy code to be used when recordingProfile is null
// once this has largely been fixed on the Android side. https://github.com/flutter/flutter/issues/119668
EncoderProfiles recordingProfile = getRecordingProfile();
if (SdkCapabilityChecker.supportsEncoderProfiles() && recordingProfile != null) {
mediaRecorderBuilder = new MediaRecorderBuilder(recordingProfile, outputFilePath);
if (SdkCapabilityChecker.supportsEncoderProfiles() && getRecordingProfile() != null) {
mediaRecorderBuilder = new MediaRecorderBuilder(getRecordingProfile(), outputFilePath);
} else {
mediaRecorderBuilder = new MediaRecorderBuilder(getRecordingProfileLegacy(), outputFilePath);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Android implementation of the camera plugin.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22

version: 0.10.8+6
version: 0.10.8+7

environment:
sdk: ">=2.19.0 <4.0.0"
Expand Down