[file_selector_web] migrate to pkg:web #5413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Nov 17, 2023
| input ?? FileUploadInputElement(); | ||
| final HTMLInputElement inputElement = | ||
| input ?? (createElementTag('input') as HTMLInputElement) | ||
| ..type = 'file'; | ||
|
|
There was a problem hiding this comment.
It'd be nice if this asserted that input.type == 'file', to retain some of the old type safety.
There was a problem hiding this comment.
not worried about this, since it's text only
| @@ -1,3 +1,7 @@ | |||
| ## 0.9.3 | |||
|
|
|||
| * Updates minimum supported SDK version to Dart 3.2. | |||
There was a problem hiding this comment.
Suggested change
| * Updates minimum supported SDK version to Dart 3.2. | |
| * Migrates web implementation to `package:web` from `dart:html`. | |
| * Updates minimum supported SDK version to Dart 3.2. |
There was a problem hiding this comment.
🤷 – for the most part, this is not a user visible change so I omitted that bit.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 20, 2023
flutter/packages@07b4b29...c5443ad 2023-11-20 [email protected] [webview_flutter] Support for handling basic authentication requests (Platform Interface) (flutter/packages#5362) 2023-11-18 [email protected] Roll Flutter from 53a57ad to 6cf9ab0 (31 revisions) (flutter/packages#5426) 2023-11-18 [email protected] [shared_preferences_web] migrate to pkg:web (flutter/packages#5414) 2023-11-18 [email protected] [ci] Roll minimum allowable Flutter to 3.10 (flutter/packages#5425) 2023-11-18 [email protected] [path_provider_android] Run tests on AVDs running Android 34 (flutter/packages#5222) 2023-11-17 [email protected] [pigeon] isEnum, isClass, fix swift casting, default values, optional method arguments, named method arguments (flutter/packages#5355) 2023-11-17 [email protected] [plugin_platform_interface] Switch mixin to `mixin class` (flutter/packages#5420) 2023-11-17 [email protected] [go_router] Fixes use of `Iterable` (flutter/packages#5421) 2023-11-17 [email protected] [pigeon] Adds `analyzer` 6.x compatibility (flutter/packages#5418) 2023-11-17 [email protected] Update release step to 3.16 (flutter/packages#5416) 2023-11-17 [email protected] [file_selector_web] migrate to pkg:web (flutter/packages#5413) 2023-11-16 [email protected] [video_player] Improve macOS frame management (flutter/packages#5078) 2023-11-16 [email protected] Roll Flutter from e8c2bb1 to 53a57ad (39 revisions) (flutter/packages#5412) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows this package to be used in a web app compiled to Wasm.
Helps unblock flutter/devtools#6606
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.