Skip to content

[pointer_interceptor] Fully publish pointer_interceptor package #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LouiseHsu
Copy link
Contributor

Addresses flutter/flutter#30143 by adding an iOS implementation, and flutter/flutter#138217 by fixing README links

This PR is Part 3/3 of #5233

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@LouiseHsu LouiseHsu marked this pull request as ready for review December 11, 2023 09:19
@LouiseHsu LouiseHsu requested a review from ditman as a code owner December 11, 2023 09:19
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@@ -14,7 +14,7 @@ The result is that Flutter widget's `onTap` (and other) handlers won't fire as e

|The problem...|
|:-:|
|![Depiction of problematic areas](https://raw.githubusercontent.com/flutter/packages/main/packages/pointer_interceptor/doc/img/affected-areas.png)|
|![Depiction of problematic areas](https://raw.githubusercontent.com/flutter/packages/main/packages/pointer_interceptor/pointer_interceptor/doc/img/affected-areas.png)|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below, we should replace main with a pin (the current head, cb6dbcdd230528c0c246c81d93386c512f9a23d0, should work fine).

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit auto-submit bot merged commit 8163731 into flutter:main Dec 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 12, 2023
flutter/packages@cb6dbcd...80aa46a

2023-12-12 [email protected] Manual roll Flutter from c642f4e to 9719097 (25 revisions) (flutter/packages#5648)
2023-12-12 [email protected] [web_benchmarks] Add support for analyzing benchmark results (flutter/packages#5630)
2023-12-11 [email protected] [pointer_interceptor] Fully publish pointer_interceptor package (flutter/packages#5640)
2023-12-11 [email protected] Manually roll Flutter (stable) from db7ef5b to b0366e0 (8 revisions) (flutter/packages#5632)
2023-12-11 [email protected] Manually roll Flutter from f35d049 to c642f4e (92 revisions) (flutter/packages#5631)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: pointer_interceptor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants