Skip to content

[ci] Allow dependencies on local_auth_ios #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

We aren't quite ready to switch the endorsement to local_auth_darwin, so allow local_auth_ios for now.

We aren't quite ready to switch the endorsement to `local_auth_darwin`,
so allow `local_auth_ios` for now.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Contributor Author

test-exempt: configuration change for a repo test

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
Copy link
Contributor

auto-submit bot commented Feb 13, 2024

auto label is removed for flutter/packages/6116, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit auto-submit bot merged commit abb04bb into flutter:main Feb 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 14, 2024
flutter/packages@9385bbb...a864254

2024-02-14 [email protected] Allow deprecated members from the Dart SDK/Flutter Framework to roll in (flutter/packages#6111)
2024-02-14 [email protected] [google_maps_flutter][iOS 12] Skip `testTakeSnapshot` (flutter/packages#6120)
2024-02-13 [email protected] [ci] Allow dependencies on local_auth_ios (flutter/packages#6116)
2024-02-13 [email protected] [url_launcher] Add `InAppBrowserConfiguration` parameter in implementations (flutter/packages#5759)
2024-02-13 [email protected] [flutter_markdown] Use Text.rich to replace RichText in Flutter Markdown (flutter/packages#6062)
2024-02-13 [email protected] [google_maps_flutter][iOS 17] takeSnapshot FIX (flutter/packages#5823)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants