Skip to content

[flutter_markdown] Replace deprecated API #6134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stuartmorgan-g
Copy link
Contributor

  • Internally, removes use of the deprecated framework methods related to textScaleFactor, in favor of the newer textScaler.
  • Plumbs that same change through the public API of this package, deprecating the style sheet's textScaleFactor and adding a textScaler.
  • Updates the min Flutter SDK to 3.16 where the new APIs were added.
  • Also updates test code that uses the deprecated renderViewElement to use rootElement instead.

Fixes flutter/flutter#143400
Fixes flutter/flutter#143448

Pre-launch Checklist

* Internally, removes use of the deprecated framework methods related to
  `textScaleFactor`, in favor of the newer `textScaler`.
* Plumbs that same change through the public API of this package,
  deprecating the style sheet's `textScaleFactor` and adding a
  `textScaler`.
* Updates the min Flutter SDK to 3.16 where the new APIs were added.
* Also updates test code that uses the deprecated `renderViewElement` to
  use `rootElement` instead.

Fixes flutter/flutter#143400
Fixes flutter/flutter#143448
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2024
@auto-submit auto-submit bot merged commit 947e34c into flutter:main Feb 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 20, 2024
flutter/packages@84ff11d...8bba41b

2024-02-20 [email protected] Roll Flutter from 064c340 to 5129806 (9 revisions) (flutter/packages#6164)
2024-02-20 [email protected] [flutter_markdown] Replace deprecated API (flutter/packages#6134)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
* Internally, removes use of the deprecated framework methods related to `textScaleFactor`, in favor of the newer `textScaler`.
* Plumbs that same change through the public API of this package, deprecating the style sheet's `textScaleFactor` and adding a `textScaler`.
* Updates the min Flutter SDK to 3.16 where the new APIs were added.
* Also updates test code that uses the deprecated `renderViewElement` to use `rootElement` instead.

Fixes flutter/flutter#143400
Fixes flutter/flutter#143448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flutter_markdown] Replace deprecated renderViewElement Replace deprecated textScaleFactor and textScaleFactorOf
2 participants