[ci] Run Windows Arm64 build tests post-submit #6166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
changed the title
loic-sharma
force-pushed
the
windows_arm64_bringup_master
branch
from
99fa0c7 to
044417c
Compare
.ci.yaml
Outdated
| @@ -1490,6 +1491,7 @@ targets: | |||
|
|
|||
| - name: Windows_x64 windows-build_all_packages stable | |||
| recipe: packages/packages | |||
| presubmit: false | |||
There was a problem hiding this comment.
I assume this was supposed to go on line 1510 instead (Win arm64 stable)?
If capacity is low, I would suggest just deleting that one instead. The chances of breaking only the Windows arm64 build of plugins only on stable seems extremely low, so we could halve our Windows arm64 usage for this repo with probably no appreciable impact on coverage.
There was a problem hiding this comment.
Good catch, fixed!
The majority of Windows Arm64 capacity is used by Dart's tests, not Flutter's tests. I think keeping the Windows Arm64 stable test is fine unless you'd prefer to remove it.
My understanding is that the infra team would need to significantly increase their number of Windows Arm64 machines to also support the try pool, so for now they're skipping that.
There was a problem hiding this comment.
I would probably remove it absent some reason we believe it will catch actual issues that the other bot won't, but I don't feel strongly about it.
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 22, 2024
flutter/packages@48048f6...078c2a3 2024-02-22 [email protected] Manual roll Flutter from 5129806 to efee280 (47 revisions) (flutter/packages#6180) 2024-02-22 [email protected] Manual roll Flutter (stable) from bae5e49 to abb292a (1 revision) (flutter/packages#6179) 2024-02-21 [email protected] [in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon (flutter/packages#6165) 2024-02-21 [email protected] [camerax] Modifies initialized camera info to reflect default AF/AE modes and the ability to set focus points for each (flutter/packages#6109) 2024-02-21 [email protected] [camerax] Implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` (flutter/packages#6059) 2024-02-21 [email protected] [various] Commit Windows build migrations (flutter/packages#6175) 2024-02-21 [email protected] [flutter_markdown] Support wasm (flutter/packages#6168) 2024-02-21 [email protected] [ci] Run Windows Arm64 build tests post-submit (flutter/packages#6166) 2024-02-21 [email protected] [url_launcher] Remove `renderView` usage (flutter/packages#6137) 2024-02-21 [email protected] [camera_android_camerax] Fix typo in readme (flutter/packages#6143) 2024-02-21 [email protected] [local_auth] Switch iOS endorsement to `local_auth_darwin` (flutter/packages#6107) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flutter try pool does not have any Windows Arm64 machines. Thus, any Windows Arm64 pre-submit tests would fail without
bringup: trueas there's no machines to run them.This change will allow us to promote the Windows Arm64 build tests out of
bringup.See: flutter/flutter#141986
Part of flutter/flutter#129813
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.