Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 1ac2978

Browse files
authored
[url_launcher_web] Fix a typo in a test name and fix quote consistency (#3010)
Fix a typo in a test name and fix quote consistency.
1 parent ba09b7f commit 1ac2978

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

packages/url_launcher/url_launcher_web/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 0.1.3+2
2+
3+
- Fix a typo in a test name and fix some style inconsistencies.
4+
15
# 0.1.3+1
26

37
- Depend explicitly on the `platform_interface` package that adds the `webOnlyWindowName` parameter.

packages/url_launcher/url_launcher_web/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/u
44
# 0.1.y+z is compatible with 1.0.0, if you land a breaking change bump
55
# the version to 2.0.0.
66
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
7-
version: 0.1.3+1
7+
version: 0.1.3+2
88

99
flutter:
1010
plugin:

packages/url_launcher/url_launcher_web/test/url_launcher_web_test.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,17 +145,17 @@ void main() {
145145

146146
verify(mockWindow.open('sms:+19725551212?body=hello%20there', ''));
147147
});
148-
test('setting oOnlyLinkTarget as _self opens the url in the same tab',
148+
test('setting webOnlyLinkTarget as _self opens the url in the same tab',
149149
() {
150-
plugin.openNewWindow("https://www.google.com",
151-
webOnlyWindowName: "_self");
150+
plugin.openNewWindow('https://www.google.com',
151+
webOnlyWindowName: '_self');
152152
verify(mockWindow.open('https://www.google.com', '_self'));
153153
});
154154

155155
test('setting webOnlyLinkTarget as _blank opens the url in a new tab',
156156
() {
157-
plugin.openNewWindow("https://www.google.com",
158-
webOnlyWindowName: "_blank");
157+
plugin.openNewWindow('https://www.google.com',
158+
webOnlyWindowName: '_blank');
159159
verify(mockWindow.open('https://www.google.com', '_blank'));
160160
});
161161

@@ -197,9 +197,9 @@ void main() {
197197
test(
198198
'mailto urls should use _blank if webOnlyWindowName is set as _blank',
199199
() {
200-
plugin.openNewWindow("mailto:[email protected]",
201-
webOnlyWindowName: "_blank");
202-
verify(mockWindow.open("mailto:[email protected]", "_blank"));
200+
plugin.openNewWindow('mailto:[email protected]',
201+
webOnlyWindowName: '_blank');
202+
verify(mockWindow.open('mailto:[email protected]', '_blank'));
203203
});
204204
});
205205
});

0 commit comments

Comments
 (0)