-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[url_launcher_web] Fix a typo in a test name and fix quote consistency #3010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change, thanks @jamesderlin!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS: Can you please bump the CHANGELOG.md and pubspec.yaml? That way we can publish this PR (even though it doesn't have external-facing changes, maybe a +1 bump is enough?)
Okay, I wasn't sure if it was worth the churn of bumping the package version. |
Thanks @jamesderlin, this way this revision can be published to pub without having to think "why is this revision failing" :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this when the CI finishes.
Published, thanks for merging! |
flutter#3010) Fix a typo in a test name and fix quote consistency.
flutter#3010) Fix a typo in a test name and fix quote consistency.
flutter#3010) Fix a typo in a test name and fix quote consistency.
Description
Fix a typo in a test name and fix quote consistency.
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?