Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher_web] Fix a typo in a test name and fix quote consistency #3010

Merged
merged 2 commits into from
Sep 9, 2020
Merged

[url_launcher_web] Fix a typo in a test name and fix quote consistency #3010

merged 2 commits into from
Sep 9, 2020

Conversation

jamesderlin
Copy link
Contributor

@jamesderlin jamesderlin commented Sep 9, 2020

Description

Fix a typo in a test name and fix quote consistency.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ditman ditman self-requested a review September 9, 2020 20:18
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, thanks @jamesderlin!

@ditman ditman self-requested a review September 9, 2020 21:08
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: Can you please bump the CHANGELOG.md and pubspec.yaml? That way we can publish this PR (even though it doesn't have external-facing changes, maybe a +1 bump is enough?)

@jamesderlin
Copy link
Contributor Author

Okay, I wasn't sure if it was worth the churn of bumping the package version.

@ditman
Copy link
Member

ditman commented Sep 9, 2020

Okay, I wasn't sure if it was worth the churn of bumping the package version.

Thanks @jamesderlin, this way this revision can be published to pub without having to think "why is this revision failing" :)

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this when the CI finishes.

@jamesderlin jamesderlin merged commit 1ac2978 into flutter:master Sep 9, 2020
@jamesderlin jamesderlin deleted the jamesderlin/typos branch September 9, 2020 22:41
@ditman
Copy link
Member

ditman commented Sep 10, 2020

Published, thanks for merging!

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Sep 18, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants