Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit ba035e9

Browse files
authored
Use testWidgets instead of test to fix failures not surfacing on CI (#3279)
1 parent 862a551 commit ba035e9

File tree

24 files changed

+58
-24
lines changed

24 files changed

+58
-24
lines changed

packages/integration_test/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.9.3
2+
3+
* Update README to mention that only `testWidgets` is supported for declaring tests.
4+
15
## 0.9.2+2
26

37
* Broaden the constraint on vm_service.

packages/integration_test/README.md

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ Create a `integration_test/` directory for your package. In this directory,
1414
create a `<name>_test.dart`, using the following as a starting point to make
1515
assertions.
1616

17+
Note: You should only use `testWidgets` to declare your tests, or errors will not be reported correctly.
18+
1719
```dart
1820
import 'package:flutter_test/flutter_test.dart';
1921
import 'package:integration_test/integration_test.dart';

packages/integration_test/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: integration_test
22
description: Runs tests that use the flutter_test API as integration tests.
3-
version: 0.9.2+2
3+
version: 0.9.3
44
homepage: https://github.com/flutter/plugins/tree/master/packages/integration_test
55

66
environment:

packages/shared_preferences/shared_preferences/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.5.13
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 0.5.12+4
26

37
* Remove unused `test` dependency.

packages/shared_preferences/shared_preferences/example/integration_test/shared_preferences_test.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void main() {
3333
preferences.clear();
3434
});
3535

36-
test('reading', () async {
36+
testWidgets('reading', (WidgetTester _) async {
3737
expect(preferences.get('String'), isNull);
3838
expect(preferences.get('bool'), isNull);
3939
expect(preferences.get('int'), isNull);
@@ -46,7 +46,7 @@ void main() {
4646
expect(preferences.getStringList('List'), isNull);
4747
});
4848

49-
test('writing', () async {
49+
testWidgets('writing', (WidgetTester _) async {
5050
await Future.wait(<Future<bool>>[
5151
preferences.setString('String', kTestValues2['flutter.String']),
5252
preferences.setBool('bool', kTestValues2['flutter.bool']),
@@ -61,7 +61,7 @@ void main() {
6161
expect(preferences.getStringList('List'), kTestValues2['flutter.List']);
6262
});
6363

64-
test('removing', () async {
64+
testWidgets('removing', (WidgetTester _) async {
6565
const String key = 'testKey';
6666
await preferences.setString(key, kTestValues['flutter.String']);
6767
await preferences.setBool(key, kTestValues['flutter.bool']);
@@ -72,7 +72,7 @@ void main() {
7272
expect(preferences.get('testKey'), isNull);
7373
});
7474

75-
test('clearing', () async {
75+
testWidgets('clearing', (WidgetTester _) async {
7676
await preferences.setString('String', kTestValues['flutter.String']);
7777
await preferences.setBool('bool', kTestValues['flutter.bool']);
7878
await preferences.setInt('int', kTestValues['flutter.int']);

packages/shared_preferences/shared_preferences/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/shared_prefere
55
# 0.5.y+z is compatible with 1.0.0, if you land a breaking change bump
66
# the version to 2.0.0.
77
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
8-
version: 0.5.12+4
8+
version: 0.5.13
99

1010
flutter:
1111
plugin:

packages/shared_preferences/shared_preferences_linux/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.0.3
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 0.0.2+4
26

37
* Remove unused `test` dependency.

packages/shared_preferences/shared_preferences_linux/example/integration_test/shared_preferences_test.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void main() {
3333
preferences.clear();
3434
});
3535

36-
test('reading', () async {
36+
testWidgets('reading', (WidgetTester _) async {
3737
expect(preferences.get('String'), isNull);
3838
expect(preferences.get('bool'), isNull);
3939
expect(preferences.get('int'), isNull);
@@ -46,7 +46,7 @@ void main() {
4646
expect(preferences.getStringList('List'), isNull);
4747
});
4848

49-
test('writing', () async {
49+
testWidgets('writing', (WidgetTester _) async {
5050
await Future.wait(<Future<bool>>[
5151
preferences.setString('String', kTestValues2['flutter.String']),
5252
preferences.setBool('bool', kTestValues2['flutter.bool']),
@@ -61,7 +61,7 @@ void main() {
6161
expect(preferences.getStringList('List'), kTestValues2['flutter.List']);
6262
});
6363

64-
test('removing', () async {
64+
testWidgets('removing', (WidgetTester _) async {
6565
const String key = 'testKey';
6666
await preferences.setString(key, kTestValues['flutter.String']);
6767
await preferences.setBool(key, kTestValues['flutter.bool']);
@@ -72,7 +72,7 @@ void main() {
7272
expect(preferences.get('testKey'), isNull);
7373
});
7474

75-
test('clearing', () async {
75+
testWidgets('clearing', (WidgetTester _) async {
7676
await preferences.setString('String', kTestValues['flutter.String']);
7777
await preferences.setBool('bool', kTestValues['flutter.bool']);
7878
await preferences.setInt('int', kTestValues['flutter.int']);

packages/shared_preferences/shared_preferences_linux/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: shared_preferences_linux
22
description: Linux implementation of the shared_preferences plugin
3-
version: 0.0.2+4
3+
version: 0.0.3
44
homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences/shared_preferences_linux
55

66
flutter:

packages/shared_preferences/shared_preferences_windows/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.0.2
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 0.0.1+3
26

37
* Remove unused `test` dependency.

packages/shared_preferences/shared_preferences_windows/example/integration_test/shared_preferences_test.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ void main() {
3737
preferences.clear();
3838
});
3939

40-
test('reading', () async {
40+
testWidgets('reading', (WidgetTester _) async {
4141
final Map<String, Object> values = await preferences.getAll();
4242
expect(values['String'], isNull);
4343
expect(values['bool'], isNull);
@@ -46,7 +46,7 @@ void main() {
4646
expect(values['List'], isNull);
4747
});
4848

49-
test('writing', () async {
49+
testWidgets('writing', (WidgetTester _) async {
5050
await Future.wait(<Future<bool>>[
5151
preferences.setValue(
5252
'String', 'String', kTestValues2['flutter.String']),
@@ -64,7 +64,7 @@ void main() {
6464
expect(values['List'], kTestValues2['flutter.List']);
6565
});
6666

67-
test('removing', () async {
67+
testWidgets('removing', (WidgetTester _) async {
6868
const String key = 'testKey';
6969
await preferences.setValue('String', key, kTestValues['flutter.String']);
7070
await preferences.setValue('Bool', key, kTestValues['flutter.bool']);
@@ -77,7 +77,7 @@ void main() {
7777
expect(values[key], isNull);
7878
});
7979

80-
test('clearing', () async {
80+
testWidgets('clearing', (WidgetTester _) async {
8181
await preferences.setValue(
8282
'String', 'String', kTestValues['flutter.String']);
8383
await preferences.setValue('Bool', 'bool', kTestValues['flutter.bool']);

packages/shared_preferences/shared_preferences_windows/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: shared_preferences_windows
22
description: Windows implementation of shared_preferences
33
homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences/shared_preferences_windows
4-
version: 0.0.1+3
4+
version: 0.0.2
55

66
flutter:
77
plugin:

packages/url_launcher/url_launcher/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 5.7.11
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 5.7.10
26

37
* Update Dart SDK constraint in example.

packages/url_launcher/url_launcher/example/integration_test/url_launcher_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import 'package:url_launcher/url_launcher.dart';
1212
void main() {
1313
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
1414

15-
test('canLaunch', () async {
15+
testWidgets('canLaunch', (WidgetTester _) async {
1616
expect(await canLaunch('randomstring'), false);
1717

1818
// Generally all devices should have some default browser.

packages/url_launcher/url_launcher/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: url_launcher
22
description: Flutter plugin for launching a URL on Android and iOS. Supports
33
web, phone, SMS, and email schemes.
44
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
5-
version: 5.7.10
5+
version: 5.7.11
66

77
flutter:
88
plugin:

packages/url_launcher/url_launcher_linux/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.0.2
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 0.0.1+4
26

37
* Update Dart SDK constraint in example.

packages/url_launcher/url_launcher_linux/example/integration_test/url_launcher_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'package:url_launcher/url_launcher.dart';
99
void main() {
1010
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
1111

12-
test('canLaunch', () async {
12+
testWidgets('canLaunch', (WidgetTester _) async {
1313
expect(await canLaunch('randomstring'), false);
1414

1515
// Generally all devices should have some default browser.

packages/url_launcher/url_launcher_linux/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: url_launcher_linux
22
description: Linux implementation of the url_launcher plugin.
3-
version: 0.0.1+4
3+
version: 0.0.2
44
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_linux
55

66
flutter:

packages/url_launcher/url_launcher_macos/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.0.2
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
# 0.0.1+9
26

37
* Update Dart SDK constraint in example.

packages/url_launcher/url_launcher_macos/example/integration_test/url_launcher_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'package:url_launcher/url_launcher.dart';
99
void main() {
1010
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
1111

12-
test('canLaunch', () async {
12+
testWidgets('canLaunch', (WidgetTester _) async {
1313
expect(await canLaunch('randomstring'), false);
1414

1515
// Generally all devices should have some default browser.

packages/url_launcher/url_launcher_macos/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: macOS implementation of the url_launcher plugin.
33
# 0.0.y+z is compatible with 1.0.0, if you land a breaking change bump
44
# the version to 2.0.0.
55
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
6-
version: 0.0.1+9
6+
version: 0.0.2
77
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_macos
88

99
flutter:

packages/url_launcher/url_launcher_windows/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.0.2
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 0.0.1+3
26

37
* Update Dart SDK constraint in example.

packages/url_launcher/url_launcher_windows/example/integration_test/url_launcher_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'package:url_launcher_platform_interface/url_launcher_platform_interface.
99
void main() {
1010
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
1111

12-
test('canLaunch', () async {
12+
testWidgets('canLaunch', (WidgetTester _) async {
1313
UrlLauncherPlatform launcher = UrlLauncherPlatform.instance;
1414

1515
expect(await launcher.canLaunch('randomstring'), false);

packages/url_launcher/url_launcher_windows/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Windows implementation of the url_launcher plugin.
33
# 0.0.y+z is compatible with 1.0.0, if you land a breaking change bump
44
# the version to 2.0.0.
55
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
6-
version: 0.0.1+3
6+
version: 0.0.2
77
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_windows
88

99
flutter:

0 commit comments

Comments
 (0)