Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Use testWidgets instead of test to fix failures not surfacing on CI #3279

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

jiahaog
Copy link
Member

@jiahaog jiahaog commented Nov 20, 2020

Description

Only testWidgets is supported for testing for package:integration_test. Errors thrown in other declarers will not be caught and reported.

Also added a note to mention this in the README for package:integration_test

Related Issues

flutter/flutter#60943

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Nov 20, 2020
@jiahaog jiahaog marked this pull request as ready for review November 20, 2020 11:16
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for investigating! And it's good to know that it was a couple of plugins (including the ones I happened to have tested this on), rather than affecting the entire repo's tests.

@jiahaog jiahaog merged commit ba035e9 into flutter:master Nov 25, 2020
@jiahaog jiahaog deleted the test-reporting-no-fail branch November 25, 2020 00:53
samandmoore added a commit to Betterment/plugins that referenced this pull request Apr 21, 2021
…m-changes

* upstream-share-final-null-release: (233 commits)
  [q-w] Update Flutter SDK constraint (flutter#3323)
  [i-p] Update Flutter SDK constraint (flutter#3322)
  [d-g] Update Flutter SDK constraint (flutter#3321)
  [a-c] Update Flutter SDK constraint (flutter#3320)
  [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309)
  Exclude null-safe plugins from testing on stable (flutter#3318)
  [documentation] [url_launcher] fix for readme code sample (flutter#3308)
  [camera] Add zoom support to platform interface (flutter#3312)
  update analysis options for nnbd (flutter#3319)
  [camera] Suppress unchecked cast warning in java test (flutter#3316)
  [image_picker] [integration_test] Fixes to make the tree green (flutter#3317)
  [camera] Expanded platform interface to support setting flash mode (flutter#3313)
  [Espresso] Android Code Inspection and Clean up (flutter#3111)
  [camera] Add `camera_platform_interface` package (flutter#3253)
  [camera] Support Android 30 (flutter#3299)
  bump integration test to 1.0.0 (flutter#3295)
  [android_alarm_manager] fix AndroidManifest.xml for android lint issue "XML tag has empty body" (flutter#3288)
  Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279)
  [file_selector_platform_interface] Migrate to cross_file package (flutter#3286)
  Fix broken link (flutter#3280)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants