Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[package_info] calling new method for BuildNumber in new android versions #1275

Merged
merged 4 commits into from
Mar 11, 2019
Merged

[package_info] calling new method for BuildNumber in new android versions #1275

merged 4 commits into from
Mar 11, 2019

Conversation

ivk1800
Copy link
Contributor

@ivk1800 ivk1800 commented Feb 24, 2019

@bparrishMines bparrishMines changed the title calling new method for BuildNumber in new android versions [package_info] calling new method for BuildNumber in new android versions Feb 27, 2019
@bparrishMines bparrishMines added bugfix submit queue The Flutter team is in the process of landing this PR. labels Feb 27, 2019
cyanglaz
cyanglaz suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment the version in pubspec.yaml and update the CHANGELOG.md. The code looks good. Please also fix the format by running To fix run "pub global activate flutter_plugin_tools && pub global run flutter_plugin_tools format". under package/ directory

@cyanglaz cyanglaz self-assigned this Mar 7, 2019
@ivk1800
Copy link
Contributor Author

ivk1800 commented Mar 10, 2019

@cyanglaz done

cyanglaz
cyanglaz suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a tiny versioning fix.

cyanglaz
cyanglaz approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyanglaz cyanglaz merged commit 5afa9d5 into flutter:master Mar 11, 2019
@cyanglaz cyanglaz mentioned this pull request Mar 11, 2019
Closed
@SandaBurido
Copy link

Please increment the version in pubspec.yaml and update the CHANGELOG.md. The code looks good. Please also fix the format by running To fix run "pub global activate flutter_plugin_tools && pub global run flutter_plugin_tools format". under package/ directory

It worked with me, tks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees

@cyanglaz cyanglaz

Labels
bugfix cla: yes submit queue The Flutter team is in the process of landing this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PackageInfoPlugin.java uses or overrides a deprecated API.
5 participants
@ivk1800 @SandaBurido @cyanglaz @googlebot @bparrishMines