Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Fix iOS MyLocationButton on iOS #2068

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Sep 18, 2019

Description

On iOS currently, when myLocationEnabled is initialized to false and later updated to true, we still see the myLocation button even though myLocationButton is always set to false.

As a developer, I would not expect setting myLocationEnabled to true to automatically show the myLocationButton as that should be controlled independently.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@felangel felangel force-pushed the bug/ios-gmaps-myLocationButton branch 2 times, most recently from 038a4f5 to 44e5741 Compare September 18, 2019 20:56
@felangel felangel force-pushed the bug/ios-gmaps-myLocationButton branch from 44e5741 to 806bbb3 Compare September 18, 2019 21:35
@felangel
Copy link
Contributor Author

@iskakaushik @mklim can you please take a look? Our team urgently needs this fix, thanks! 🙏

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix!

@mklim mklim merged commit 3972c5d into flutter:master Sep 19, 2019
@felangel
Copy link
Contributor Author

felangel commented Sep 20, 2019

Thanks @mklim! How often are updates published to pub?

@mklim
Copy link
Contributor

mklim commented Sep 20, 2019

@felangel they're pushed manually, so it's a bit inconsistent. (flutter/flutter#27258) I was waiting for CI to finish on the merge commit here. There was an error but it was unrelated to this PR, so I just pushed it. You should be seeing it now.

mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants