Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[instrumentation_adapter] Migrate example to AndroidX #2075

Merged
merged 2 commits into from
Sep 20, 2019

Conversation

blasten
Copy link

@blasten blasten commented Sep 20, 2019

Description

Migrate the example app to AndroidX

Related Issues

Log: https://api.cirrus-ci.com/v1/task/5954826887757824/logs/main.log

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@blasten blasten changed the title Instrumentation adapter [instrumentation_adapter] Migrate example to AndroidX Sep 20, 2019
Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten force-pushed the instrumentation_adapter branch from df2b2c6 to 9582b0f Compare September 20, 2019 01:11
@blasten blasten merged commit a2b5a77 into flutter:master Sep 20, 2019
@blasten blasten deleted the instrumentation_adapter branch September 20, 2019 15:36
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants