[image_picker] Fix a crash when picking video on iOS 13 and above.

[miguelpruivo]

Description

Fixes an issue that could result in a crash when picking videos from gallery on iOS 13 or above.

Related Issues

#41046

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I signed the CLA.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

• No, this is not a breaking change.

[alexei-g-aloteq]

What maintainers waiting for? Plugin is unusable on iOS 13 without this patch!

[cyanglaz]

Thank you for providing this PR. I left some comments.

[ailic88]

@miguelpruivo @cyanglaz please be aware that this fix introduce a new issue when source is camera(not gallery).

[miguelpruivo]

@miguelpruivo @cyanglaz please be aware that this fix introduce a new issue when source is camera(not gallery).

Hi, thank you @ailic88, do you mind to provide more details?

Edit: You are completely right, good catch @ailic88. It was because the recorded videos from camera don't actually need to be cached and thus the temporary path was exactly the same when caching (thus, an error was being thrown). Just committed a fix.

Thank you.

[cyanglaz]

@miguelpruivo Please update the pubspec and changelog

[miguelpruivo]

Done @cyanglaz.

[trey-rosius]

If only you guys knew how badly some of us flutter devs need the image_picker working properly on ios 13.Been waiting since September

[miguelpruivo]

I still don’t get it why this is taking so long @trey-rosius.

[alexei-g-aloteq]

It's shame for official Flutter plugin to have CRITICAL issue are not fixed for such long time. Start thinking that Flutter is not right choice when you need reliability.

[cyanglaz]

LGTM! Let's fix the CI failure and land this.

[cyanglaz]

@miguelpruivo Could you rebase the upstream/master, it might fix the CI.

[miguelpruivo]

Done @cyanglaz.

[cyanglaz]

@miguelpruivo Thanks, let's see if the CI passes. If not, I'll merge in #2275 and then we can try it again.

[trey-rosius]

Any Progress with this ?

[miguelpruivo]

@cyanglaz is all good to go for a while. This should be merge ASAP to address severe crash issues on iOS 13 when picking from gallery.