[camera] Update and migrate iOS example project

[jmagman]

Description

1. Let Move flutter_assets to App.framework flutter#26630 flutter_assets migrator run
2. Run pod install so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see Remove xcconfigs from template Copy Bundle Resources build phases flutter#38724
5. Let Xcode 11 update build settings
6. Remove DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one)
7. Looks like this was last run with use_frameworks!? Let CocoaPods build as libraries instead of frameworks.
8. Remove ARCHS, which was causing a compilation error

Related Issues

Get to a buildable baseline so I can start working on flutter/flutter#41007.

Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the [Flutter Style Guide].
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
• I updated CHANGELOG.md to add a description of the change.
• I signed the [CLA].
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[jmagman]

Does a change to the example app require a build suffix version bump?

[mklim]

LGTM pending one nit on the versioning bump and a test exemption.

Lately we've re-emphasized that all PRs need tests, following the Flutter style guide. This PR is already being effectively tested by our existing infra because it's a change to the example app's iOS config, and our infra make sure that the example app still builds on iOS. I don't think there's a meaningful test to be added here on top of what we already have. @Hixie can we get an exemption for this one and the other build refactoring patches @jmagman is landing?

[mklim]

nit: This should be 0.5.4+3. Pub changes it's semver scheme for when the plugin is above or below 1.0.0. When it's above 1.0.0 it's major.minor.patch but when it's below it's 0.major.minor+patch.

[jmagman]

Thanks for the catch, sorry about that!

[jmagman]

@Hixie can we get an exemption for this one and the other build refactoring patches @jmagman is landing?

These changes get us to a baseline where the iOS example apps are migrated and build, so I can start more easily adding tests without including all these diff lines in a PR for every plugin, mostly to make those future reviews smaller and more focused.

[mklim]

@Hixie can we get an exemption for this one and the other build refactoring patches @jmagman is landing?

I talked with @Hixie offline. The DEVELOPMENT_TEAM removal is something that we could/should test for here. We should add something to our CI that greps our examples and makes sure that it's an empty string.

I still think we can't land that exactly in this PR because other plugins are failing so CI would go red. But @jmagman either you or I can land it as a followup to these fixes to prevent this from regressing. I can add it in myself once these are landed.

[jmagman]

I talked with @Hixie offline. The DEVELOPMENT_TEAM removal is something that we could/should test for here. We should add something to our CI that greps our examples and makes sure that it's an empty string.

Better yet, it shouldn't be present at all. Let me fix that in this change.

[jmagman]

our infra make sure that the example app still builds on iOS.

I don't see how anything could be testing this builds. Here's what it looks like on master:

$ cd packages/camera/example/ios 
$ xcodebuild CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY=- EXPANDED_CODE_SIGN_IDENTITY=- -workspace Runner.xcworkspace -scheme Runner -configuration Debug
...

** BUILD FAILED **


The following build commands failed:
	CpResource /Users/m/Projects/plugins/packages/camera/example/ios/Flutter/flutter_assets /Users/m/Library/Developer/Xcode/DerivedData/Runner-awfyzlddjninmfeqadavdewbrcar/Build/Products/Debug-iphoneos/Runner.app/flutter_assets
(1 failure)

[mklim]

our infra make sure that the example app still builds on iOS.

I don't see how anything could be testing this builds. Here's what it looks like on master:

The Cirrus task is here: https://github.com/flutter/plugins/blob/master/.cirrus.yml#L76-L78. That goes through a couple layers, but it ends up running flutter build ios --no-codesign https://github.com/flutter/plugin_tools/blob/194fcac6a8e4da55153b35765a4de59c9148d061/lib/src/build_examples_command.dart#L40-L48. I think the --no-codesign is probably why it's green in CI.

[jmagman]

our infra make sure that the example app still builds on iOS.

I don't see how anything could be testing this builds. Here's what it looks like on master:

The Cirrus task is here: https://github.com/flutter/plugins/blob/master/.cirrus.yml#L76-L78. That goes through a couple layers, but it ends up running flutter build ios --no-codesign https://github.com/flutter/plugin_tools/blob/194fcac6a8e4da55153b35765a4de59c9148d061/lib/src/build_examples_command.dart#L40-L48. I think the --no-codesign is probably why it's green in CI.

Ah, it's because it runs the migrator every time. Note the "Removing obsolete reference to flutter_assets from Runner.app" line.

$ flutter build ios --no-codesign
Warning: Building for device with codesigning disabled. You will have to manually codesign before deploying to device.
Building io.flutter.plugins.cameraExample for device (ios-release)...
Removing obsolete reference to flutter_assets from Runner.app