[sensor] Support v2 android embedder. #2164

cyanglaz · 2019-10-07T23:13:24Z

Description

Minimum work to migrate to the new android embedding.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

…sor_migrate

bparrishMines

LGTM

packages/sensors/android/src/main/java/io/flutter/plugins/sensors/SensorsPlugin.java

…ors/SensorsPlugin.java Co-Authored-By: Maurice Parrish <[email protected]>

googlebot · 2019-10-11T21:14:50Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-11T21:42:44Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

matthew-carroll

LGTM from a new plugin API perspective.

matthew-carroll · 2019-10-11T22:02:22Z

packages/sensors/android/src/main/java/io/flutter/plugins/sensors/SensorsPlugin.java

-  public void onCancel(Object arguments) {
-    sensorManager.unregisterListener(sensorEventListener);
+  public void onDetachedFromEngine(FlutterPluginBinding binding) {
+    accelerometerChannel.setStreamHandler(null);


Recommendation: If you've defined a setupEventChannels() that contains setup behavior, consider also defining a teardownEventChannels() that does the opposite, rather than directly implementing that behavior in onDetachedFromEngine().

matthew-carroll · 2019-10-11T22:04:44Z

packages/sensors/example/android/app/src/main/AndroidManifest.xml

                  android:launchMode="singleTop"
                  android:theme="@android:style/Theme.Black.NoTitleBar"
                  android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|layoutDirection"
                  android:hardwareAccelerated="true"
                  android:windowSoftInputMode="adjustResize">
+        </activity>
+        <activity android:name=".MainActivity"
+            android:launchMode="singleTop"


FYI @cyanglaz @amirh @mklim @collinjackson @bparrishMines @kroikie I don't think we require the singleTop launch mode any more. If you discover the opposite, please let me know, but it is probably best not to include that in the example unless it is actually required. From an add-to-app perspective, single top is a problem.

googlebot · 2019-10-14T16:12:33Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-15T22:57:51Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

bparrishMines · 2019-10-15T22:59:18Z

@googlebot *Note the CLA failure is due to my personal email being my primary email address. So, @cyanglaz and I are verifying the CLA manually.

googlebot · 2019-10-15T23:03:45Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…sor_migrate

googlebot · 2019-10-21T20:14:16Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-21T20:31:53Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-21T20:33:19Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

migrate

2e9cf9f

googlebot added the cla: yes label Oct 7, 2019

Chris Yang added 8 commits October 7, 2019 16:28

refactoring

360484c

rename activities

623b10b

non public

992115f

Update StreamHandlerImpl.java

c2db84c

Update MainActivity.java

63cff27

Update EmbeddingV1Activity.java

74a3097

dependency script

5641b07

Merge branch 'sensor_migrate' of github.com:cyanglaz/plugins into sen…

493fbca

…sor_migrate

bparrishMines approved these changes Oct 10, 2019

View reviewed changes

packages/sensors/android/src/main/java/io/flutter/plugins/sensors/SensorsPlugin.java Outdated Show resolved Hide resolved

Chris Yang and others added 5 commits October 11, 2019 13:40

fix gradle script

958ac3c

remove debug print

c2e4152

Update gradle.properties

b0280ee

Update build.gradle

4fc4882

Update packages/sensors/android/src/main/java/io/flutter/plugins/sens…

4a1e1ca

…ors/SensorsPlugin.java Co-Authored-By: Maurice Parrish <[email protected]>

googlebot added cla: no and removed cla: yes labels Oct 11, 2019

cyanglaz requested a review from matthew-carroll October 11, 2019 21:42

cyanglaz added cla: yes and removed cla: no labels Oct 11, 2019

matthew-carroll approved these changes Oct 11, 2019

View reviewed changes

review fixes

d4f17a8

googlebot added cla: no and removed cla: yes labels Oct 14, 2019

cyanglaz mentioned this pull request Oct 15, 2019

[url_launcher] Migrate to the new embedding #2157

Merged

12 tasks

pubspec and gradle

fd07b5d

cyanglaz added the cla: yes label Oct 15, 2019

Chris Yang added 2 commits October 15, 2019 16:01

Merge branch 'master' into sensor_migrate

f8c5e2a

revert some formatting change

2ee7ea6

googlebot added cla: no and removed cla: yes labels Oct 15, 2019

cyanglaz changed the title ~~[sensor] migrate to the new android embedding.~~ [sensor] Support v2 android embedder. Oct 15, 2019

Chris Yang added 5 commits October 15, 2019 16:08

Update MainActivity.java

096c6b5

Update pubspec.yaml

8d44c5e

remove android x constraint

77340b2

Merge branch 'sensor_migrate' of github.com:cyanglaz/plugins into sen…

6777439

…sor_migrate

remove extra space

4fb6d02

cyanglaz added cla: yes and removed cla: no labels Oct 21, 2019

matthew-carroll approved these changes Oct 21, 2019

View reviewed changes

formatting and lower the min sdk bound

b656059

googlebot added cla: no and removed cla: yes labels Oct 21, 2019

cyanglaz added cla: yes and removed cla: no labels Oct 21, 2019

cyanglaz merged commit 3ad2d83 into flutter:master Oct 21, 2019

cyanglaz deleted the sensor_migrate branch October 21, 2019 20:45

cyanglaz mentioned this pull request Oct 22, 2019

[video_player] Add v2 embedding support #2226

Merged

13 tasks

mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019

[sensor] Support v2 android embedder. (flutter#2164)

e0fe080

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019

[sensor] Support v2 android embedder. (flutter#2164)

8af33b3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[sensor] Support v2 android embedder. #2164

[sensor] Support v2 android embedder. #2164

Uh oh!

cyanglaz commented Oct 7, 2019 •

edited

Loading

Uh oh!

bparrishMines left a comment

Uh oh!

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

matthew-carroll left a comment

Uh oh!

matthew-carroll Oct 11, 2019

Uh oh!

matthew-carroll Oct 11, 2019

Uh oh!

googlebot commented Oct 14, 2019

Uh oh!

googlebot commented Oct 15, 2019

Uh oh!

bparrishMines commented Oct 15, 2019

Uh oh!

googlebot commented Oct 15, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

Uh oh!

[sensor] Support v2 android embedder. #2164

[sensor] Support v2 android embedder. #2164

Uh oh!

Conversation

cyanglaz commented Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

matthew-carroll left a comment

Choose a reason for hiding this comment

Uh oh!

matthew-carroll Oct 11, 2019

Choose a reason for hiding this comment

Uh oh!

matthew-carroll Oct 11, 2019

Choose a reason for hiding this comment

Uh oh!

googlebot commented Oct 14, 2019

Uh oh!

googlebot commented Oct 15, 2019

Uh oh!

bparrishMines commented Oct 15, 2019

Uh oh!

googlebot commented Oct 15, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

Uh oh!

cyanglaz commented Oct 7, 2019 •

edited

Loading