-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter] Added 'allowsInlineMediaPlayback' property #2227
Conversation
Nice, waiting for this too |
Hey, I just created a (much simpler) PR to address this issue as well: #2309 Personally I would like to see your approach get merged because it gives the developer more control over the widget from Flutter code. Out of curiosity, may I ask what is holding up this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sarbagyastha thank you for the PR! I think this may be the way to go.
There is only 1 comment on the e2e test, really. Even a property is no-op, we should still somewhat test it to be sure nothing breaks in the future.
The PR also changes some of the Set syntax. It has to be done at some point, but we should mention that in the change log, along with the increment of the Dart version constraints.
Could you please address those items & rebase to latest master
? Thank you!
@@ -456,6 +457,69 @@ void main() { | |||
isPaused = await controller.evaluateJavascript('isPaused();'); | |||
expect(isPaused, _webviewBool(false)); | |||
}); | |||
|
|||
test('Video plays inline when allowsInlineMediaPlayback is true', () async { | |||
if (Platform.isIOS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should run on all platforms (so that we can be sure future plugin / platform versions don't break).
Can you clearly observe a different behavior on Android? If so, perhaps this could be a separate else branch to verify that.
Thanks for the PR! We have migrated this plugin to null safe, would you be able to rebase and re-apply your patch? |
My git-fu isn't very strong but given that this now says "unknown repository" on top, I assume the fork (and likely branch) was deleted. I will rebase this and open a new PR. |
Moved over to: #3334 |
Description
The PR includes following changes:
allowsInlineMediaPlayback
property to WebView to support inline media playback in iOS.Set
.Related Issues
#25630
#42099
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?