This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Use platform interface #2557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Feb 27, 2020
ditman
reviewed
Feb 27, 2020
packages/path_provider/path_provider/test/path_provider_test.dart
Outdated
Show resolved
Hide resolved
ditman
reviewed
Feb 28, 2020
ditman
reviewed
Feb 28, 2020
packages/path_provider/path_provider/test/path_provider_test.dart
Outdated
Show resolved
Hide resolved
ditman
approved these changes
Feb 29, 2020
|
LGTM! |
ditman
approved these changes
Mar 2, 2020
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
* Add dart file * Rename file * add interface, rename files, add methods to class * Add to method channel, not done * Add dart file * Rename file * Adds method channel test * Remove prints * Fix imports and version * Format and commentas * Space * Rename apis to path and provide only the string from the platform * Add test and remove null * Format * Add export * Add imports * Completed apis * Fix and works * Improve tests * Remove asyncs * Add imports * Completed apis * Fix and works * Update version * Finish test * Make results per test * Fix * Add dependency * Fix typo nad enum * Change interface version * Address comments * Remove mock call * Typo and import * Remove file
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* Add dart file * Rename file * add interface, rename files, add methods to class * Add to method channel, not done * Add dart file * Rename file * Adds method channel test * Remove prints * Fix imports and version * Format and commentas * Space * Rename apis to path and provide only the string from the platform * Add test and remove null * Format * Add export * Add imports * Completed apis * Fix and works * Improve tests * Remove asyncs * Add imports * Completed apis * Fix and works * Update version * Finish test * Make results per test * Fix * Add dependency * Fix typo nad enum * Change interface version * Address comments * Remove mock call * Typo and import * Remove file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the core plugin to make use of the platform_interface
Related Issues
flutter/flutter#46307
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?