Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

fix(video_player): buffering state events missing on Android & Web (fixes flutter/flutter#28494) #2563

Merged
merged 22 commits into from
Dec 17, 2020
Merged

fix(video_player): buffering state events missing on Android & Web (fixes flutter/flutter#28494) #2563

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0c3ff8a
Fix buffering state on Android
kmod-midori Feb 27, 2020
8174d49
Update version of video_player
kmod-midori Feb 27, 2020
5f297a5
Update CHANGELOG.md
kmod-midori Feb 27, 2020
f6e800c
Merge remote master
kmod-midori Mar 22, 2020
b11318a
Merge remote-tracking branch 'upstream/master' into fix-android-buffe…
kmod-midori May 22, 2020
0d27352
Merge tag 'video_player-v0.10.11+2' into fix-android-buffering
kmod-midori Jul 3, 2020
1697976
Merge branch 'master' into fix-android-buffering
Salakar Dec 7, 2020
c19d5e3
refactor: update changelog & pubspec version to latest version
Salakar Dec 7, 2020
ef78567
fix: android not correctly sending `bufferingEnd` event
Salakar Dec 7, 2020
b3d734b
refactor: android sending unnecessary `bufferingUpdate` event.
Salakar Dec 7, 2020
7efdab7
refactor: make `videoPlayerPlatform` visible for testing
Salakar Dec 7, 2020
ff2eb55
tests: add integration test for video buffering events
Salakar Dec 7, 2020
16abc3e
fix: implement bufferingStart/End for Web
Salakar Dec 7, 2020
a813434
chore: bump pubspec version & add changelog
Salakar Dec 7, 2020
ca34285
tests: buffering integration test should run on Android or Web only
Salakar Dec 7, 2020
78faecf
docs: changelog grammar fix
Salakar Dec 17, 2020
e4f7c6e
refactor: move `isBuffering` state to event listener
Salakar Dec 17, 2020
c58c1f7
refactor(android): define a `setBuffering` method to be used instead …
Salakar Dec 17, 2020
5240014
refactor(web): define a `setBuffering` method to be used instead of c…
Salakar Dec 17, 2020
081ce00
refactor: revert `visibleForTesting` addition and test using `network…
Salakar Dec 17, 2020
7810db5
refactor: revert removal of manual `sendBufferingUpdate` call
Salakar Dec 17, 2020
be84d1e
Merge branch 'master' into fix-android-buffering
Salakar Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/video_player/video_player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.10.8+3

* Fix issue where `isBuffering` is not updating on Android.

## 0.10.8+2

* Replace deprecated `getFlutterEngine` call on Android.
Expand Down
9 changes: 8 additions & 1 deletion ...player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,15 @@ public void onCancel(Object o) {
public void onPlayerStateChanged(final boolean playWhenReady, final int playbackState) {
if (playbackState == Player.STATE_BUFFERING) {
sendBufferingUpdate();
Map<String, Object> event = new HashMap<>();
event.put("event", "bufferingStart");
eventSink.success(event);
} else if (playbackState == Player.STATE_READY) {
if (!isInitialized) {
if (isInitialized) {
Map<String, Object> event = new HashMap<>();
event.put("event", "bufferingEnd");
eventSink.success(event);
} else {
isInitialized = true;
sendInitialized();
}
Expand Down