Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] support localizedFallbackTitle in IOSAuthMessages #2616

Closed
wants to merge 11 commits into from

Conversation

kaparray
Copy link

@kaparray kaparray commented Mar 23, 2020

Description

Add support localizedFallbackTitle in IOSAuthMessages.

Related Issues

flutter/flutter#53205

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kaparray
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kaparray
Copy link
Author

@a14n please approve or give an answer about PR

@a14n
Copy link
Contributor

a14n commented Apr 24, 2020

Sorry I'm not the right person to review this PR.

@kaparray
Copy link
Author

@a14n Sorry 😐 Who review this PR? I need this update in my production app. Thx for help )

@a14n
Copy link
Contributor

a14n commented Apr 27, 2020

You can try to reach to someone on discord in hackers-ecosystem channel.

@kaparray
Copy link
Author

kaparray commented Aug 4, 2020

What about the review?

@stuartmorgan-g
Copy link
Contributor

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

With the addition of #2489 it seems like this should only be supported in the non-biometric path, so this PR would need to be updated.

I also suspect that in that path we want the default to be nil rather than @""; deciding how the default behavior should be handled (whether to disable, or use nil) needs discussion, and due to the subtleties there this PR would definitely need a test.

@stuartmorgan-g
Copy link
Contributor

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants