-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[local_auth] support localizedFallbackTitle in IOSAuthMessages #2616
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@a14n please approve or give an answer about PR |
Sorry I'm not the right person to review this PR. |
@a14n Sorry 😐 Who review this PR? I need this update in my production app. Thx for help ) |
You can try to reach to someone on discord in hackers-ecosystem channel. |
What about the review? |
We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog. With the addition of #2489 it seems like this should only be supported in the non-biometric path, so this PR would need to be updated. I also suspect that in that path we want the default to be |
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks! |
Description
Add support localizedFallbackTitle in IOSAuthMessages.
Related Issues
flutter/flutter#53205
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?