Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] A fix for stopImageStream method which solves a stale images bug #2655

Closed

Conversation

topnax
Copy link

@topnax topnax commented Apr 15, 2020

Description

This PR fixes an issue where after starting another image stream subscription after the previous one was stopped, one or more images received were from the previous stream (they were stale). Better description and example is presented in the related issue.

Related Issues

flutter/flutter#54837

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

topnax added 2 commits April 15, 2020 11:27
…ream, first few received images would be stale (typically images from the end of the first stream).

This issue was caused by the absence of removing the image listener right after the cancellation of the image stream.
@acoutts
Copy link
Contributor

acoutts commented Jun 18, 2020

This would be great if it were merged.

@Isakdl
Copy link

Isakdl commented Jul 25, 2020

What is stopping this from being merged? Would love this fix as it currently causes a bug in my app.

@mvanbeusekom
Copy link
Contributor

A fix for this bug is implemented and merged with PR #3344, therefore I will be closing this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants