Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Fix a typo in README #3095

Closed
wants to merge 3 commits into from
Closed

Conversation

exKAZUu
Copy link

@exKAZUu exKAZUu commented Oct 1, 2020

Description

I guess multiple keyboard should be multiple keyboard issues.

Related Issues

Nothing.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

I guess `multiple keyboard` should be `multiple keyboard issues`.
@exKAZUu exKAZUu requested a review from amirh as a code owner October 1, 2020 08:29
@stuartmorgan-g stuartmorgan-g added the p: webview_flutter Edits files for a webview_flutter plugin label Jan 29, 2021
@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

Could you merge to the latest master to resolve the CI failures, and add a version bump? Once that's done I can get this reviewed and landed.

@stuartmorgan-g stuartmorgan-g removed the request for review from amirh June 29, 2021 19:54
exKAZUu and others added 2 commits June 30, 2021 06:20
I guess `multiple keyboard` should be `multiple keyboard issues`.
@exKAZUu
Copy link
Author

exKAZUu commented Jun 29, 2021

@stuartmorgan I've merged the latest master to my branch. Note that this PR modifies only packages/webview_flutter/README.md (i.e. only the document) and fixes only a typo, so I think I don't need to bump a version.

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan I've merged the latest master to my branch. Note that this PR modifies only packages/webview_flutter/README.md (i.e. only the document) and fixes only a typo, so I think I don't need to bump a version.

Please read the first FAQ in the documentation I linked to in my comment above.

@stuartmorgan-g
Copy link
Contributor

Looks like we ended up with two versions of the same PR due to the triage delay; closing in favor of #3266 which was already reviewed and has the version changes. Sorry about that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: webview_flutter Edits files for a webview_flutter plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants